feat(x/ecocredit): add admin to project info #888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #888 +/- ##
==========================================
+ Coverage 73.82% 73.84% +0.02%
==========================================
Files 172 173 +1
Lines 22209 22239 +30
==========================================
+ Hits 16395 16423 +28
- Misses 4672 4673 +1
- Partials 1142 1143 +1
Flags with carried forward coverage won't be shown. Click here to find out more. |
technicallyty
approved these changes
Mar 15, 2022
Comment on lines
24
to
27
| string class_id = 2; | ||
| string class_id = 3; | ||
|
|
||
| // issuer is the issuer of the credit batches for this project. | ||
| string issuer = 3; | ||
| // admin is the admin of the project. | ||
| string admin = 2; |
There was a problem hiding this comment.
nit: maybe we should keep the field order? 1,2,3...,n
There was a problem hiding this comment.
We have not used ecocredit v1 in a release and this is more consistent with project info.
There was a problem hiding this comment.
i meant to just move string admin = 2; below string project_id = 1;instead of after string class_id = 3; which currently makes it 1,3,2
There was a problem hiding this comment.
Whoops... That was the intention it seems but somehow only half complete.
aleem1314
approved these changes
Mar 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #884
Add
adminto project info allowing a project to be updated in the future.Also update event to use
adminrather thanissuer.Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change