Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(x/data): add CLI commands for data resolver #866

Merged
merged 24 commits into from
Mar 15, 2022
Merged

feat(x/data): add CLI commands for data resolver #866

merged 24 commits into from
Mar 15, 2022

Conversation

aleem1314
Copy link
Contributor

@aleem1314 aleem1314 commented Mar 9, 2022 •
edited by zube bot
Loading

Description

Closes: #860

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@aleem1314
Copy link
Contributor Author

make proto-gen is not working in my system.

./scripts/protocgen.sh
Generating gogo proto code
cp: cannot stat 'github.com/regen-network/regen-ledger/*': No such file or directory

Can someone generate proto files @ryanchristo @technicallyty?

@codecov
Copy link

codecov bot commented Mar 11, 2022 •
edited
Loading

Codecov Report

Merging #866 (6cc2462) into master (6588f5b) will increase coverage by 46.58%.
The diff coverage is 95.07%.

❗ Current head 6cc2462 differs from pull request most recent head fec6201. Consider uploading reports for the commit fec6201 to get more accurate results

@@             Coverage Diff             @@
##           master     #866       +/-   ##
===========================================
+ Coverage   27.44%   74.02%   +46.58%     
===========================================
  Files         195      171       -24     
  Lines       72193    22115    -50078     
===========================================
- Hits        19812    16371     -3441     
+ Misses      50646     4631    -46015     
+ Partials     1735     1113      -622
Flag Coverage Δ
experimental-codecov 73.99% <95.07%> (+46.57%) ⬆️
stable-codecov 66.58% <0.00%> (+42.52%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@aleem1314 aleem1314 marked this pull request as ready for review March 14, 2022 13:43
technicallyty
technicallyty approved these changes Mar 14, 2022
View reviewed changes
Copy link
Contributor

@technicallyty technicallyty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

scripts/test_cover.sh Outdated Show resolved Hide resolved
ryanchristo
ryanchristo approved these changes Mar 14, 2022
View reviewed changes
Copy link
Member

@ryanchristo ryanchristo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK. Looks great. One small suggestion.

x/data/client/tx.go Outdated Show resolved Hide resolved
@ryanchristo ryanchristo changed the title feat: add CLI commands for data resolver feat(x/data): add CLI commands for data resolver Mar 15, 2022
@aleem1314 @ryanchristo
Update x/data/client/tx.go
abac36e 
Co-authored-by: Ryan Christoffersen <12519942+ryanchristo@users.noreply.github.com>
@ryanchristo ryanchristo enabled auto-merge (squash) March 15, 2022 14:37
@ryanchristo ryanchristo merged commit 7195314 into master Mar 15, 2022
@ryanchristo ryanchristo deleted the aleem/860-data-resolver-cli branch March 15, 2022 14:39
anilcse
anilcse approved these changes Mar 15, 2022
View reviewed changes
Copy link
Contributor

@anilcse anilcse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, just a small question

x/data/client/query.go
Url: args[0],
})

return print(ctx, res, err)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aren't we using PrintProto?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we are using PrintProto print().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@technicallyty technicallyty technicallyty approved these changes

@ryanchristo ryanchristo ryanchristo approved these changes

@anilcse anilcse anilcse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement CLI commands for data resolver
4 participants
@aleem1314 @anilcse @ryanchristo @technicallyty