Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(x/ecocredit): update proto files #848

Merged
merged 6 commits into from
Mar 7, 2022
Merged

Conversation

ryanchristo
Copy link
Member

@ryanchristo ryanchristo commented Mar 4, 2022

Description

Closes: #827

This pull request includes the following updates:

  • remove ecocredit/v1apha2
  • remove ecocredit/basket/v1apha1
  • rename ecocredit/v1beta1 to ecocredit/v1
  • rename ecocredit/marketplace/v1beta1 to ecocredit/marketplace/v1
  • rename ecocredit/orderbook/v1beta1 to ecocredit/orderbook/v1alpha1

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@ryanchristo ryanchristo changed the title chora(x/ecocredit): update proto files chore(x/ecocredit): update proto files Mar 4, 2022
@ryanchristo ryanchristo marked this pull request as ready for review March 4, 2022 22:36
@ryanchristo
Copy link
Member Author

cc @technicallyty do you mind running make proto-gen on this pull request 🙏

@clevinson
Copy link
Member

🎉 awesomeeeee

thanks @ryanchristo for taking the time to get this set up.

Looks like the .pb.go and .pb.gw.go files from x/ecocredit/v1alpha1 didn't actually get removed from x/ecocredit directory. Should we delete these (e.g. x/ecocredit/types.pb.go)?

Also can you clarify how we're thinking abt managing both v1alpha1 and v1 versions in parallel on regen ledger v4.0? Would we support both APIs? Or drop v1alpha1 entirely before cutting the release? I'm not sure if there's a need to support it once the chain upgrades, except for possibly providing backwards compatibility with the registry application (which is maybe actually a good idea...)

@clevinson
Copy link
Member

clevinson commented Mar 7, 2022

Looks like the .pb.go and .pb.gw.go files from x/ecocredit/v1alpha1 didn't actually get removed from x/ecocredit directory. Should we delete these (e.g. x/ecocredit/types.pb.go)?

Speaking w/ @ryanchristo sounds like this is being taken care of in followups (or in some preexisting PRs that @technicallyty is working on)

@ryanchristo ryanchristo merged commit 8ab92e7 into master Mar 7, 2022
@ryanchristo ryanchristo deleted the ryan/827-ecocredit-proto branch March 7, 2022 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate ecocredit proto files to v1
3 participants