Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: proto lint #709

Merged
merged 3 commits into from
Jan 27, 2022
Merged

fix: proto lint #709

merged 3 commits into from
Jan 27, 2022

Conversation

aaronc
Copy link
Member

@aaronc aaronc commented Jan 27, 2022

Description

This resolves issues with proto lint introduced in #700. It also renames the ProjectSequence.project_id field to class_id - an issue that was identified in most merge review.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@codecov
Copy link

codecov bot commented Jan 27, 2022

Codecov Report

Merging #709 (a73d11e) into master (6699a38) will decrease coverage by 0.16%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #709      +/-   ##
==========================================
- Coverage   74.90%   74.74%   -0.17%     
==========================================
  Files         117      118       +1     
  Lines       19497    19542      +45     
==========================================
+ Hits        14605    14606       +1     
- Misses       3918     3963      +45     
+ Partials      974      973       -1     
Flag Coverage Δ
experimental-codecov 74.84% <ø> (-0.07%) ⬇️
stable-codecov 67.69% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

proto/regen/ecocredit/v1beta1/state.proto Outdated Show resolved Hide resolved
proto/regen/ecocredit/v1beta1/state.proto Outdated Show resolved Hide resolved
aaronc and others added 2 commits January 27, 2022 16:54
Co-authored-by: Ryan Christoffersen <12519942+ryanchristo@users.noreply.github.com>
Co-authored-by: Ryan Christoffersen <12519942+ryanchristo@users.noreply.github.com>
@aaronc aaronc enabled auto-merge (squash) January 27, 2022 21:54
@aaronc aaronc merged commit 4afe978 into master Jan 27, 2022
@aaronc aaronc deleted the aaronc/fix-proto-lint branch January 27, 2022 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants