Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DNM: feat(x/ecocredit): start migrating ORM tables to declarative protobuf #651

Closed
wants to merge 1 commit into from

Conversation

aaronc
Copy link
Member

@aaronc aaronc commented Nov 19, 2021

Description

DO NOT MERGE

I would like to start at least expressing the ORM schema in protobuf even if we can't quite generate the ORM from protobuf yet. This PR proposes an approach for that.

I've noticed some issues with our current schema - for instance CreditType embedded in ClassInfo is denormalized and we really want to avoid that. So I think if we at least start describing a relational schema declaratively (whcih we can do in protobuf) we'll be able to evaluate the design better.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@aaronc aaronc changed the title feat(x/ecocredit): start migrating ORM tables to declarative protobuf feat(x/ecocredit): start migrating ORM tables to declarative protobuf (DNM) Nov 19, 2021
@aaronc aaronc changed the title feat(x/ecocredit): start migrating ORM tables to declarative protobuf (DNM) DNM: feat(x/ecocredit): start migrating ORM tables to declarative protobuf Nov 19, 2021
@codecov
Copy link

codecov bot commented Nov 19, 2021

Codecov Report

Merging #651 (7760038) into master (9c97674) will decrease coverage by 0.12%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #651      +/-   ##
==========================================
- Coverage   73.70%   73.58%   -0.13%     
==========================================
  Files         104      105       +1     
  Lines       14948    14832     -116     
==========================================
- Hits        11018    10914     -104     
- Misses       3153     3164      +11     
+ Partials      777      754      -23     
Flag Coverage Δ
experimental-codecov 73.58% <ø> (-0.13%) ⬇️
stable-codecov 65.33% <ø> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@blushi blushi self-assigned this Nov 23, 2021
@robert-zaremba
Copy link
Collaborator

done in #700

@aaronc aaronc closed this Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants