Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add gas per-loop-iteration in ecocredit messages (#519) #526

Merged
merged 5 commits into from
Sep 16, 2021

Conversation

ruhatch
Copy link
Contributor

@ruhatch ruhatch commented Sep 8, 2021

Description

Add fixed gas cost to ecocredit messages per-loop-iteration

Closes: #519


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@codecov
Copy link

codecov bot commented Sep 8, 2021

Codecov Report

Merging #526 (ba8e3cc) into master (c179d8a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #526   +/-   ##
=======================================
  Coverage   77.51%   77.52%           
=======================================
  Files         100      100           
  Lines       12755    12760    +5     
=======================================
+ Hits         9887     9892    +5     
  Misses       2276     2276           
  Partials      592      592           
Flag Coverage Δ
experimental-codecov 77.52% <100.00%> (+<0.01%) ⬆️
stable-codecov 68.31% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@blushi blushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also charge some extra gas in isCreatorAllowListed? (it's more or less the same logic in x/authz and x/feegrant)
cc/ @clevinson @ruhatch

@atheeshp
Copy link
Contributor

atheeshp commented Sep 9, 2021

Should we also charge some extra gas in isCreatorAllowListed? (it's more or less the same logic in x/authz and x/feegrant)
cc/ @clevinson @ruhatch

I think we have to.

Copy link
Contributor

@atheeshp atheeshp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@aleem1314 aleem1314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@blushi blushi merged commit 0254627 into master Sep 16, 2021
@blushi blushi deleted the ruhatch/eco-loop-gas branch September 16, 2021 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should we be charging some set gas per loop step in ecocredit msg server?
5 participants