-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add gas per-loop-iteration in ecocredit messages (#519) #526
Conversation
Codecov Report
@@ Coverage Diff @@
## master #526 +/- ##
=======================================
Coverage 77.51% 77.52%
=======================================
Files 100 100
Lines 12755 12760 +5
=======================================
+ Hits 9887 9892 +5
Misses 2276 2276
Partials 592 592
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we also charge some extra gas in isCreatorAllowListed
? (it's more or less the same logic in x/authz and x/feegrant)
cc/ @clevinson @ruhatch
I think we have to. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Add fixed gas cost to ecocredit messages per-loop-iteration
Closes: #519
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change