Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix ecocredit proto comments #522

Merged
merged 2 commits into from
Sep 8, 2021
Merged

Conversation

ryanchristo
Copy link
Member

@ryanchristo ryanchristo commented Sep 8, 2021

Description

Ref: #350

Fix generated ecocredit documentation (swagger config and proto comments).


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct docs: prefix in the PR title
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the documentation writing guidelines
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct docs: prefix in the PR title
  • confirmed all author checklist items have been addressed
  • confirmed that this PR only changes documentation
  • reviewed content for consistency
  • reviewed content for thoroughness
  • reviewed content for spelling and grammar
  • tested instructions (if applicable)

@codecov
Copy link

codecov bot commented Sep 8, 2021

Codecov Report

Merging #522 (69a8fbc) into master (8cae9dd) will not change coverage.
The diff coverage is n/a.

❗ Current head 69a8fbc differs from pull request most recent head b4d677c. Consider uploading reports for the commit b4d677c to get more accurate results

@@           Coverage Diff           @@
##           master     #522   +/-   ##
=======================================
  Coverage   77.51%   77.51%           
=======================================
  Files         100      100           
  Lines       12755    12755           
=======================================
  Hits         9887     9887           
  Misses       2276     2276           
  Partials      592      592           
Flag Coverage Δ
experimental-codecov 77.51% <ø> (ø)
stable-codecov 68.29% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@ruhatch ruhatch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ryanchristo ryanchristo enabled auto-merge (squash) September 8, 2021 16:55
@ryanchristo ryanchristo merged commit 50eaced into master Sep 8, 2021
@ryanchristo ryanchristo deleted the ryan/ecocredit-audit branch September 8, 2021 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants