Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Update to SDK v0.43.0 (with PermLockedAcct fork) #482

Merged
merged 7 commits into from
Aug 18, 2021

Conversation

clevinson
Copy link
Member

@clevinson clevinson commented Aug 17, 2021

Description

Closes: #188

  • Update to v0.43.0 final release
  • Adds support for on-chain creation of Permanent Locked Accounts (via fork). To be used by Regen Foundation when distributing funds for their prototype days.

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@clevinson clevinson changed the title Update regen-ledger to v0.43.0-regen-1 feat: Add permanent locked vesting accounts (via v0.43.0-regen-1 fork) Aug 17, 2021
@clevinson clevinson changed the title feat: Add permanent locked vesting accounts (via v0.43.0-regen-1 fork) deps: Update to SDK v0.43.0 (with PermLockedAcct fork) Aug 17, 2021
@clevinson clevinson changed the title deps: Update to SDK v0.43.0 (with PermLockedAcct fork) !deps: Update to SDK v0.43.0 (with PermLockedAcct fork) Aug 18, 2021
@clevinson clevinson changed the title !deps: Update to SDK v0.43.0 (with PermLockedAcct fork) deps!: Update to SDK v0.43.0 (with PermLockedAcct fork) Aug 18, 2021
@clevinson clevinson changed the title deps!: Update to SDK v0.43.0 (with PermLockedAcct fork) feat!: Update to SDK v0.43.0 (with PermLockedAcct fork) Aug 18, 2021
@codecov
Copy link

codecov bot commented Aug 18, 2021

Codecov Report

Merging #482 (e6a59fc) into master (4198cd4) will increase coverage by 0.08%.
The diff coverage is 100.00%.

❗ Current head e6a59fc differs from pull request most recent head 7df7789. Consider uploading reports for the commit 7df7789 to get more accurate results

@@            Coverage Diff             @@
##           master     #482      +/-   ##
==========================================
+ Coverage   76.90%   76.99%   +0.08%     
==========================================
  Files         101      101              
  Lines       12522    12512      -10     
==========================================
+ Hits         9630     9633       +3     
+ Misses       2288     2276      -12     
+ Partials      604      603       -1     
Flag Coverage Δ
experimental-codecov 76.99% <100.00%> (+0.08%) ⬆️
stable-codecov 61.05% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Collaborator

@robert-zaremba robert-zaremba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK. I'm not sure why we need to add replace directive for github.com/cosmos/cosmos-sdk in go.mod

@@ -25,6 +25,8 @@ replace google.golang.org/grpc => google.golang.org/grpc v1.33.2

replace github.com/gogo/protobuf => github.com/regen-network/protobuf v1.3.2-alpha.regen.4

replace github.com/cosmos/cosmos-sdk => github.com/regen-network/cosmos-sdk v0.43.0-regen-1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need this?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We added a small PR to our 0.43 fork regen-network/cosmos-sdk#42

Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK but x/capability fix lgtm

@amaury1093 amaury1093 enabled auto-merge (squash) August 18, 2021 09:16
@amaury1093 amaury1093 merged commit 6c7517f into master Aug 18, 2021
@amaury1093 amaury1093 deleted the clevinson/v0.43.0-regen-1-update branch August 18, 2021 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Permanently Locked accounts + Msg for account creation on-chain
3 participants