-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add x/ecocredit
simulations
#480
Conversation
…into aleem/416-ecocredit-simulations
Codecov Report
@@ Coverage Diff @@
## master #480 +/- ##
==========================================
- Coverage 77.46% 75.42% -2.04%
==========================================
Files 100 104 +4
Lines 12764 13330 +566
==========================================
+ Hits 9887 10054 +167
- Misses 2287 2679 +392
- Partials 590 597 +7
Flags with carried forward coverage won't be shown. Click here to find out more. |
…regen-network/regen-ledger into aleem/416-ecocredit-simulations
Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com>
Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com>
…regen-network/regen-ledger into aleem/416-ecocredit-simulations
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this looks good overall. Mainly wondering about adding more randomness to the generated values.
Co-authored-by: Ru Horlick <ruperthorlick@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks :)
Description
Closes: #416
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change