Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add x/ecocredit simulations #480

Merged
merged 44 commits into from
Sep 17, 2021
Merged

Conversation

aleem1314
Copy link
Contributor

@aleem1314 aleem1314 commented Aug 16, 2021

Description

Closes: #416


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@codecov
Copy link

codecov bot commented Aug 19, 2021

Codecov Report

Merging #480 (992d602) into master (744489e) will decrease coverage by 2.03%.
The diff coverage is 29.13%.

❗ Current head 992d602 differs from pull request most recent head f828bf0. Consider uploading reports for the commit f828bf0 to get more accurate results

@@            Coverage Diff             @@
##           master     #480      +/-   ##
==========================================
- Coverage   77.46%   75.42%   -2.04%     
==========================================
  Files         100      104       +4     
  Lines       12764    13330     +566     
==========================================
+ Hits         9887    10054     +167     
- Misses       2287     2679     +392     
- Partials      590      597       +7     
Flag Coverage Δ
experimental-codecov 75.42% <29.13%> (-2.04%) ⬇️
stable-codecov 66.33% <29.13%> (-1.92%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@aleem1314 aleem1314 marked this pull request as ready for review August 26, 2021 10:57
@aleem1314 aleem1314 requested review from blushi and ruhatch September 6, 2021 16:23
Copy link
Contributor

@ruhatch ruhatch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks good overall. Mainly wondering about adding more randomness to the generated values.

x/ecocredit/simulation/genesis.go Outdated Show resolved Hide resolved
x/ecocredit/simulation/genesis.go Outdated Show resolved Hide resolved
x/ecocredit/simulation/genesis.go Outdated Show resolved Hide resolved
x/ecocredit/simulation/genesis.go Outdated Show resolved Hide resolved
x/ecocredit/simulation/genesis.go Outdated Show resolved Hide resolved
x/ecocredit/simulation/operations.go Outdated Show resolved Hide resolved
x/ecocredit/simulation/operations.go Outdated Show resolved Hide resolved
x/ecocredit/simulation/operations.go Show resolved Hide resolved
x/ecocredit/simulation/operations.go Outdated Show resolved Hide resolved
x/ecocredit/simulation/operations.go Outdated Show resolved Hide resolved
types/module/server/manager.go Show resolved Hide resolved
types/module/server/manager.go Show resolved Hide resolved
types/module/server/manager.go Show resolved Hide resolved
Copy link
Contributor

@anilcse anilcse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aleem1314 aleem1314 requested a review from ruhatch September 9, 2021 10:22
Copy link
Contributor

@ruhatch ruhatch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks :)

@ryanchristo ryanchristo enabled auto-merge (squash) September 16, 2021 15:11
@ryanchristo ryanchristo merged commit d18d139 into master Sep 17, 2021
@ryanchristo ryanchristo deleted the aleem/416-ecocredit-simulations branch September 17, 2021 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ecocredit simulations
5 participants