-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove Request
suffix in Msgs
#422
Conversation
request
suffixRequest
suffix in Msgs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Tests still need to be fixed. We can safely ignore the |
Has anyone looked into the test coverage issue here? |
I'm trying to fix this. |
Codecov Report
@@ Coverage Diff @@
## master #422 +/- ##
==========================================
- Coverage 56.63% 56.60% -0.04%
==========================================
Files 59 59
Lines 3752 3754 +2
==========================================
Hits 2125 2125
- Misses 1356 1357 +1
- Partials 271 272 +1
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pre-approving, I left one comment that is good to keep in mind for the future but is out of scope of this PR.
@@ -639,6 +639,7 @@ github.com/otiai10/mint v1.3.0/go.mod h1:F5AjcsTsWUqX+Na9fpHb52P8pcRX2CI6A3ctIT9 | |||
github.com/otiai10/mint v1.3.2 h1:VYWnrP5fXmz1MXvjuUvcBrXSjGE6xjON+axB/UrpO3E= | |||
github.com/otiai10/mint v1.3.2/go.mod h1:/yxELlJQ0ufhjUwhshSj+wFjZ78CnZ48/1wtmBH1OTc= | |||
github.com/pact-foundation/pact-go v1.0.4/go.mod h1:uExwJY4kCzNPcHRj+hCR/HBbOOIwwtUjcrb0b5/5kLM= | |||
github.com/pariz/gountries v0.0.0-20200430155801-1c6a393df9c7/go.mod h1:U0ETmPPEsfd7CpUKNMYi68xIOL8Ww4jPZlaqNngcwqs= |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this here?
ecocreditGenesisState := ecocredit.DefaultGenesisState() | ||
ecocreditGenesisBytes, err := cdc.MarshalJSON(ecocreditGenesisState) | ||
require.NoError(err) | ||
|
||
genesisData := map[string]json.RawMessage{ | ||
group.ModuleName: genesisBytes, | ||
ecocredit.ModuleName: ecocreditGenesisBytes, | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not so fond of having to put ecocredit module related logic in the group module tests but I guess we have no other choice with the current setup, unless we create public functions InitGenesis
and ExportGenesis
that could be tested individually without the server (they would be used in serverImpl.InitGenesis
and serverImpl.ExportGenesis
) similarly to what we have with the invariants tests. But then that would force us to set up all the tables again in the tests while this is already handled by the integration test suite here so this is not ideal either. So let's keep it as is for now until we come to a better solution in terms of module wiring / test setup.
Description
Closes: #399
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change