feat!: ecocredit genesis import and export

[aleem1314]

Description

Closes: #187

---

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

• included the correct type prefix in the PR title
• added ! to the type prefix if API or client breaking change
• targeted the correct branch (see PR Targeting)
• provided a link to the relevant issue or specification
• followed the guidelines for building modules
• included the necessary unit and integration tests
• added a changelog entry to CHANGELOG.md
• included comments for documenting Go code
• updated the relevant documentation or specification
• reviewed "Files changed" and left comments if necessary
• confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

• confirmed the correct type prefix in the PR title
• confirmed ! in the type prefix if API or client breaking change
• confirmed all author checklist items have been addressed
• reviewed state machine logic
• reviewed API design and naming
• reviewed documentation is accurate
• reviewed tests and test coverage
• manually tested (if applicable)

[codecov]

Codecov Report

Merging #389 (c4ea83b) into master (2ddd722) will decrease coverage by 0.01%.
The diff coverage is 77.37%.

@@            Coverage Diff             @@
##           master     #389      +/-   ##
==========================================
- Coverage   76.96%   76.94%   -0.02%     
==========================================
  Files          99      101       +2     
  Lines       12111    12520     +409     
==========================================
+ Hits         9321     9634     +313     
- Misses       2230     2286      +56     
- Partials      560      600      +40     

Flag	Coverage Δ
experimental-codecov	76.94% <77.37%> (-0.02%)	⬇️
stable-codecov	59.01% <75.05%> (+0.75%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

[blushi]

I haven't looked at the implementation yet, just some comments regarding the proto definitions

[aleem1314]

@aaronc could you have a final look?

[aaronc]

Logic looks correct now.

Can we simplify this API? Won't block on it because I know this has been in progress for a while, so pre-approving. But I think we can merge tradable and retired balances and supplies.

[clevinson]

Few comments on the formatting of the Supply / Balance messages. Can you take a look at this tomorrow @aleem1314 and then I think we're good to merge!

[robert-zaremba]

I was posting similar comment to NFT: how about putting genesis into a separate package, eg x/ecocredit/genesis - it has different domain than RPC messages. Or even we can have two packages:

• x/ecocredit/ -- for all things related to RPC
• x/ecocredit/dal -- for all things related to storage (data access layer)

[clevinson]

I agree with this separation in principle, but don't want to block this PR on it. adding a new versioning scheme outside of the one for just modules (which is the current setup) is something that I'd like to make sure is the direction we want to go in across the SDK before doing it just on our own modules.

We will already need to be doing a version upgrade for ecocredit module proto files in regen ledger v3 as we expect the API to change possibly quite a bit. So seems fine IMO to not block the v2.0 upgrade on this question.

[clevinson]

Few merge conflicts now, but pending those getting fixed, I think this is good to go.

There's some stuff where we may want to add some additional validation to InitGenesis, namely that all the CreditType values in any given genesis credit classes actually correspond to a CreditType in the ecocredit's genesis params.

Happy to move that to a separate issue and just continue a discussion there to see what makes the most sense after this PR gets merged.

Thanks @aleem1314!