Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Votes sum invariant #330

Merged
merged 148 commits into from
Jun 8, 2021
Merged

feat: Votes sum invariant #330

merged 148 commits into from
Jun 8, 2021

Conversation

likhita-809
Copy link
Contributor

@likhita-809 likhita-809 commented Apr 22, 2021 •
edited by zube bot
Loading

Closes: #326
Add an invariant to verify that proposal tally corresponds to the sum of vote weights and proposal VoteState corresponds to the vote choice

likhita-809 and others added 30 commits February 22, 2021 16:27
@likhita-809
adding RegisterInvariants to Configuration
e31c19a
@likhita-809
fixing failed tests
6d2092a
@likhita-809
fix failing tests
9c19e84
@likhita-809
fix lint issues
1e51704
@likhita-809
add-TallyVotesInvariant
a5338df
@likhita-809
remove temp
f353d41
@likhita-809
fix lint issues
89a43db
@likhita-809
Merge branch 'master' of github.com:regen-network/regen-ledger into l…
74aabf7 
…ikhita/add-invariants
@likhita-809
adding invariants
0a64ab2
@likhita-809
changes to invariant
ad719bf
@likhita-809
fix lint issues
0c1556a
@likhita-809
addressing requested changes
822d61d
@likhita-809
"Remove getAllProposals"
a60f625
@likhita-809
"Remove invariant.go"
fd08c73
@likhita-809
"Change naming conventions"
3f6c079
@likhita-809
"Fix lint issues"
96c61f2
@likhita-809
Merge branch 'master' into likhita/add-invariants
ec7fba5
@likhita-809
change naming conventions
8f39c1e
@likhita-809
"Change naming conventions"
d223200
@likhita-809
Merge branch 'master' into likhita/add-invariants
23c0167
@likhita-809
Merge branch 'master' into likhita/add-invariants
d62f5e9 
# Conflicts:
#	go.mod
@likhita-809
Merge branch 'master' into likhita/add-invariants
76be926 
# Conflicts:
#	go.mod
@anilcse
Merge branch 'master' into likhita/add-invariants
ef878de
@likhita-809 @blushi
Update types/module/server/manager.go
68a0e0f 
Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com>
@likhita-809 @blushi
Update types/module/server/manager.go
af62bac 
Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com>
@likhita-809 @blushi
Update types/module/server/manager.go
95f27b3 
Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com>
@likhita-809 @blushi
Update types/module/server/manager.go
6783ecd 
Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com>
@likhita-809 @blushi
Update types/module/server/manager.go
94e8b93 
Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com>
@likhita-809 @blushi
Update types/module/server/manager.go
3b8328e 
Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com>
@likhita-809 @blushi
Update x/group/server/server.go
3dd8029 
Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com>
blushi
blushi reviewed May 19, 2021
View reviewed changes
x/group/server/invariants.go Outdated Show resolved Hide resolved
x/group/server/invariants.go Outdated Show resolved Hide resolved
x/group/server/invariants.go Outdated Show resolved Hide resolved
@blushi
Copy link
Member

blushi commented May 19, 2021

@likhita-809 could you resolve the conflicts?

@blushi
Copy link
Member

blushi commented May 19, 2021 •
edited
Loading

I've been thinking through this invariant a little bit and I believe it might bring some issues in the following case:
Some proposal is created and then there are some votes, the proposal passes and is executed. Later on, the corresponding group member weights are changed, which means that then it will result in a broken invariant while it shouldn't, because the invariant will get the current weights instead of the ones that were used at the time of the proposal.
So I can see several ways to solve this:

  • either we restrict the invariant to proposals where corresponding group account and group haven't changed (same versions as the one saved as part of the Proposal)
  • or we wait until we have some kind of snapshots implemented before going further with this

@likhita-809 likhita-809 reopened this May 19, 2021
blushi
blushi requested changes May 21, 2021
View reviewed changes
x/group/server/invariants.go Outdated Show resolved Hide resolved
x/group/server/invariants.go Outdated Show resolved Hide resolved
x/group/server/invariants.go Outdated Show resolved Hide resolved
x/group/server/invariants.go Outdated Show resolved Hide resolved
x/group/server/invariants.go Outdated Show resolved Hide resolved
x/group/server/invariants.go Outdated Show resolved Hide resolved
x/group/server/invariants.go Outdated Show resolved Hide resolved
x/group/server/invariants.go Outdated Show resolved Hide resolved
x/group/server/invariants.go Outdated Show resolved Hide resolved
@likhita-809 likhita-809 requested a review from blushi May 21, 2021 12:11
blushi
blushi reviewed Jun 2, 2021
View reviewed changes
x/group/server/invariants.go Outdated Show resolved Hide resolved
@likhita-809 likhita-809 requested a review from blushi June 3, 2021 05:36
blushi
blushi approved these changes Jun 3, 2021
View reviewed changes
Copy link
Member

@blushi blushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pre-approving, pending small nits

x/group/server/invariants.go Outdated Show resolved Hide resolved
x/group/server/invariants_test.go Outdated Show resolved Hide resolved
x/group/server/invariants_test.go Outdated Show resolved Hide resolved
@amaury1093 amaury1093 enabled auto-merge (squash) June 7, 2021 15:05
@amaury1093 amaury1093 merged commit ae66672 into master Jun 8, 2021
@amaury1093 amaury1093 deleted the likhita/proposal-tally-invariant branch June 8, 2021 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atheeshp atheeshp atheeshp approved these changes

@blushi blushi blushi approved these changes

@robert-zaremba robert-zaremba Awaiting requested review from robert-zaremba

@aaronc aaronc Awaiting requested review from aaronc

@aleem1314 aleem1314 Awaiting requested review from aleem1314

@amaury1093 amaury1093 Awaiting requested review from amaury1093

@anilcse anilcse Awaiting requested review from anilcse

@clevinson clevinson Awaiting requested review from clevinson

Assignees

@amaury1093 amaury1093

@blushi blushi

@atheeshp atheeshp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add new group invariant to verify that proposal tally corresponds to the sum of votes
5 participants
@likhita-809 @blushi @atheeshp @amaury1093 @anilcse