Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(x/ecocredit): forward contract API #2152

Closed
wants to merge 2 commits into from
Closed

Conversation

aaronc
Copy link
Member

@aaronc aaronc commented Jan 30, 2024

Description

This adds an API which allows project admins to issue forward contract batches for their project which are not linked to any credit class and have no credit type nor start/end dates, but otherwise function like regular credit batches with respect to the marketplace and other functionality.

This strategy distinctly from approaches we consider earlier, makes zero assumptions about how credits will be fulfilled. The only requirement would be that forward contracts get "retired". This has the advantage of making it easier to deploy this functionality because we don't need to get the requirements of relating forwards to credits correctly and can have lots of flexibility off chain. But it does impose the limitation that this functionality doesn't exist on chain and must be coordinated off chain


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@aaronc aaronc changed the title feat(x/ecocredit): forward contract support feat(x/ecocredit): forward contract API Jan 30, 2024
@aaronc aaronc marked this pull request as ready for review January 30, 2024 20:03
@aaronc aaronc requested a review from clevinson January 30, 2024 20:05
@aaronc
Copy link
Member Author

aaronc commented Feb 6, 2024

Closing in favor of #2150 which handles this via multiple credit classes per project.

@aaronc aaronc closed this Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant