-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(x/ecocredit/marketplace): marketplace fee API #2151
Conversation
…onc/marketplace-fees
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think to start with is perfect!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added comment to clarify a unit
Thanks @robert-zaremba. Addressed your comments |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2151 +/- ##
==========================================
- Coverage 73.19% 73.11% -0.08%
==========================================
Files 234 236 +2
Lines 13802 13820 +18
==========================================
+ Hits 10102 10105 +3
- Misses 2960 2976 +16
+ Partials 740 739 -1
|
Description
Defines the protobuf API for marketplace fees.
In this model there are buyer a seller percentage fees for every marketplace sale. If the buyer fee is 5% and the seller fee is 5% and 100tokens of credits are sold, the buyer pays an extra 5tokens totaling a payment of 105tokens and the seller receives 95tokens. 10tokens would be deposited in the fee pool. If the denom is uregen, then the 10uregen get burned.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change