Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: fix lint errors using latest golangci #1838

Merged
merged 1 commit into from
Mar 21, 2023
Merged

Conversation

ryanchristo
Copy link
Member

Description

This pull request fixes the latest lint errors using the latest version of golangci.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@codecov
Copy link

codecov bot commented Mar 20, 2023

Codecov Report

Merging #1838 (7e59347) into main (7673be6) will increase coverage by 0.10%.
The diff coverage is 72.09%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1838      +/-   ##
==========================================
+ Coverage   73.01%   73.11%   +0.10%     
==========================================
  Files         228      228              
  Lines       13581    13556      -25     
==========================================
- Hits         9916     9912       -4     
+ Misses       2934     2917      -17     
+ Partials      731      727       -4     
Impacted Files Coverage Δ
x/ecocredit/base/types/v1/params.go 16.07% <0.00%> (+2.22%) ⬆️
x/intertx/module/ibc_module.go 14.28% <ø> (ø)
x/ecocredit/basket/keeper/msg_take.go 59.55% <64.00%> (-0.23%) ⬇️
app/testsuite/helpers.go 84.54% <100.00%> (ø)
x/ecocredit/base/keeper/msg_send.go 69.23% <100.00%> (+1.82%) ⬆️
...redit/base/keeper/query_class_creator_allowlist.go 62.50% <100.00%> (ø)
x/ecocredit/base/keeper/query_class_fee.go 60.00% <100.00%> (ø)
x/ecocredit/base/types/v1/msg_bridge_receive.go 93.05% <100.00%> (-0.28%) ⬇️
x/ecocredit/basket/keeper/msg_put.go 67.97% <100.00%> (+1.30%) ⬆️
x/ecocredit/basket/keeper/query_fees.go 62.50% <100.00%> (ø)
... and 2 more

@ryanchristo ryanchristo marked this pull request as ready for review March 20, 2023 23:51
@ryanchristo ryanchristo requested a review from a team March 20, 2023 23:51
@ryanchristo ryanchristo merged commit 5c132ff into main Mar 21, 2023
@ryanchristo ryanchristo deleted the ryan/fix-update-lint branch March 21, 2023 15:49
@ryanchristo
Copy link
Member Author

@mergify backport release/v5.1.x

@mergify
Copy link
Contributor

mergify bot commented Mar 21, 2023

backport release/v5.1.x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Mar 21, 2023
ryanchristo added a commit that referenced this pull request Mar 21, 2023
Co-authored-by: Ryan Christoffersen <12519942+ryanchristo@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants