Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add batches new metadata #1831

Merged

Conversation

blushi
Copy link
Member

@blushi blushi commented Mar 16, 2023

Description

New metadata added:
C01-001-20150101-20151231-001
C01-001-20150101-20151231-002
C01-001-20150101-20151231-003
C01-001-20150101-20151231-004
C01-001-20150101-20151231-005
C01-002-20190101-20191231-001
C01-002-20190101-20191231-002
C01-002-20190101-20191231-003
C01-002-20190101-20191231-004
C01-003-20150701-20160630-001
C02-001-20180101-20181231-001
C02-003-20200630-20220629-001
C02-002-20211012-20241013-001
C02-004-20210102-20211207-001
C01-002-20190101-20191231-005
C01-001-20150101-20151231-006
C01-002-20190101-20191231-006


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@blushi blushi requested a review from a team March 16, 2023 09:44
Copy link
Member

@ryanchristo ryanchristo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK. Double checked all metadata is unique, using the appropriate schema references, and the information provided matches the appropriate credit class and project.

@ryanchristo ryanchristo merged commit a07c637 into ryan/v5.1-state-migration Mar 16, 2023
@ryanchristo ryanchristo deleted the marie/v5.1-state-migration-iri branch March 16, 2023 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants