-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add grpc gateway annotations #183
Conversation
Codecov Report
@@ Coverage Diff @@
## master #183 +/- ##
==========================================
+ Coverage 56.36% 60.05% +3.69%
==========================================
Files 59 56 -3
Lines 3717 3425 -292
==========================================
- Hits 2095 2057 -38
+ Misses 1351 1104 -247
+ Partials 271 264 -7
Flags with carried forward coverage won't be shown. Click here to find out more. |
…into aleem/182-grpc-gateway
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would be cool to have 1 or 2 integration tests too, for a later PR
…into aleem/182-grpc-gateway
@aleem1314 Now that the group module is merged, we will also need to add grpc gateway annotations to it. |
It seems that this fails because of the custom code generator. Maybe we should fix it in the SDK first? ref: cosmos/cosmos-sdk#9302 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this is going in the right direction (unfortunately for now). Pre-approving.
We can also remove the protoc-gen-go-cosmos2
folder.
Co-authored-by: Anil Kumar Kammari <anil@vitwit.com>
…work/regen-ledger into aleem/182-grpc-gateway
closes: #182