Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add grpc gateway annotations #183

Merged
merged 29 commits into from
Jul 14, 2021
Merged

feat: Add grpc gateway annotations #183

merged 29 commits into from
Jul 14, 2021

Conversation

aleem1314
Copy link
Contributor

@aleem1314 aleem1314 commented Nov 19, 2020

closes: #182

@codecov
Copy link

codecov bot commented Nov 19, 2020

Codecov Report

Merging #183 (bcd2573) into master (8b95557) will increase coverage by 3.69%.
The diff coverage is 85.36%.

❗ Current head bcd2573 differs from pull request most recent head 562611d. Consider uploading reports for the commit 562611d to get more accurate results

@@            Coverage Diff             @@
##           master     #183      +/-   ##
==========================================
+ Coverage   56.36%   60.05%   +3.69%     
==========================================
  Files          59       56       -3     
  Lines        3717     3425     -292     
==========================================
- Hits         2095     2057      -38     
+ Misses       1351     1104     -247     
+ Partials      271      264       -7     
Flag Coverage Δ
experimental-codecov 60.05% <85.36%> (+3.69%) ⬆️
stable-codecov 60.05% <85.36%> (+3.69%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

third_party/proto/google/protobuf/any.proto Outdated Show resolved Hide resolved
proto/regen/ecocredit/v1alpha1/query.proto Outdated Show resolved Hide resolved
proto/regen/ecocredit/v1alpha1/query.proto Outdated Show resolved Hide resolved
proto/regen/data/v1alpha1/query.proto Outdated Show resolved Hide resolved
proto/regen/data/v1alpha1/query.proto Outdated Show resolved Hide resolved
Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be cool to have 1 or 2 integration tests too, for a later PR

proto/regen/data/v1alpha1/query.proto Outdated Show resolved Hide resolved
proto/regen/data/v1alpha1/query.proto Outdated Show resolved Hide resolved
proto/regen/ecocredit/v1alpha1/query.proto Outdated Show resolved Hide resolved
proto/regen/ecocredit/v1alpha1/query.proto Outdated Show resolved Hide resolved
proto/regen/ecocredit/v1alpha1/query.proto Outdated Show resolved Hide resolved
@blushi
Copy link
Member

blushi commented Feb 1, 2021

@aleem1314 Now that the group module is merged, we will also need to add grpc gateway annotations to it.

@amaury1093
Copy link
Contributor

It seems that this fails because of the custom code generator. Maybe we should fix it in the SDK first? ref: cosmos/cosmos-sdk#9302

@aleem1314 aleem1314 changed the title Add grpc gateway annotations feat: Add grpc gateway annotations Jul 6, 2021
scripts/protocgen.sh Outdated Show resolved Hide resolved
Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is going in the right direction (unfortunately for now). Pre-approving.

We can also remove the protoc-gen-go-cosmos2 folder.

.codecov.yml Outdated Show resolved Hide resolved
proto/regen/data/v1alpha2/query.proto Outdated Show resolved Hide resolved
proto/regen/ecocredit/v1alpha1/query.proto Outdated Show resolved Hide resolved
@aleem1314 aleem1314 requested a review from anilcse July 9, 2021 05:35
@aaronc aaronc enabled auto-merge (squash) July 14, 2021 15:37
@aaronc aaronc merged commit ce62101 into master Jul 14, 2021
@aaronc aaronc deleted the aleem/182-grpc-gateway branch July 14, 2021 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add grpc-gateway endpoints to proto files
6 participants