-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: remove references to hambach testnet #1779
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you remove hambach information from the following page?
I don't think we need to separate mainnet and redwood instructions on the following page if they will always be the same:
Strange, my local repo has this already changed. I pushed again
…On Wed, Feb 15, 2023, 12:57 PM Ryan Christoffersen ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In docs/validators/get-started/install-regen.md
<#1779 (comment)>
:
> @@ -28,18 +28,6 @@ Check out the genesis version:
git checkout v1.0.0
```
-*For Redwood Testnet:*
-
-```bash
-git checkout v1.0.0
-```
-
-*For Hambach Testnet:*
-
-```bash
-git checkout v4.0.0
-```
-
Build and install the `regen` binary:
*For Regen Mainnet:*
These are no longer needed if the instructions apply to all (i.e. mainnet
and redwood)
—
Reply to this email directly, view it on GitHub
<#1779 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACBIMSXWNKD4STITAPQK3GTWXUYJFANCNFSM6AAAAAAU4HZPIE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Ryan Christoffersen <12519942+ryanchristo@users.noreply.github.com> (cherry picked from commit cbaefd3)
Description
Closes: #1770
This PR removes any references to Hambach testnet.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change