Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: remove references to hambach testnet #1779

Merged
merged 6 commits into from
Feb 15, 2023
Merged

docs: remove references to hambach testnet #1779

merged 6 commits into from
Feb 15, 2023

Conversation

dpdanpittman
Copy link
Contributor

Description

Closes: #1770

This PR removes any references to Hambach testnet.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@dpdanpittman dpdanpittman requested a review from a team February 15, 2023 01:21
@dpdanpittman dpdanpittman changed the title removed references to hambach DOCS: Removed references to hambach Feb 15, 2023
@dpdanpittman dpdanpittman changed the title DOCS: Removed references to hambach docs: Removed references to hambach Feb 15, 2023
Copy link
Member

@ryanchristo ryanchristo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove hambach information from the following page?

I don't think we need to separate mainnet and redwood instructions on the following page if they will always be the same:

docs/ledger/get-started/README.md Outdated Show resolved Hide resolved
docs/ledger/get-started/README.md Outdated Show resolved Hide resolved
@dpdanpittman
Copy link
Contributor Author

dpdanpittman commented Feb 15, 2023 via email

Copy link
Member

@ryanchristo ryanchristo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

docs/ledger/get-started/README.md Outdated Show resolved Hide resolved
@ryanchristo ryanchristo added the backport/v5.0.x backport to release/v5.0.x branch label Feb 15, 2023
@ryanchristo ryanchristo changed the title docs: Removed references to hambach docs: remove references to hambach testnet Feb 15, 2023
@ryanchristo ryanchristo merged commit cbaefd3 into main Feb 15, 2023
@ryanchristo ryanchristo deleted the dan/hambach branch February 15, 2023 20:39
mergify bot pushed a commit that referenced this pull request Feb 15, 2023
Co-authored-by: Ryan Christoffersen <12519942+ryanchristo@users.noreply.github.com>
(cherry picked from commit cbaefd3)
ryanchristo pushed a commit that referenced this pull request Feb 15, 2023
Co-authored-by: Daniel Pittman <dpdanpittman@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/v5.0.x backport to release/v5.0.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Hambach instructions from documentation
2 participants