Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(x/ecocredit): don't allow self transfer in MsgSend #1674

Merged
merged 3 commits into from
Dec 9, 2022

Conversation

aleem1314
Copy link
Contributor

@aleem1314 aleem1314 commented Dec 9, 2022

Description

Ref: #1660


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@codecov
Copy link

codecov bot commented Dec 9, 2022

Codecov Report

Merging #1674 (aa58c17) into main (605edb1) will decrease coverage by 0.01%.
The diff coverage is 50.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1674      +/-   ##
==========================================
- Coverage   73.07%   73.06%   -0.02%     
==========================================
  Files         228      228              
  Lines       13409    13415       +6     
==========================================
+ Hits         9799     9802       +3     
- Misses       2894     2896       +2     
- Partials      716      717       +1     
Impacted Files Coverage Δ
x/ecocredit/base/keeper/msg_send.go 67.88% <0.00%> (-1.52%) ⬇️
x/ecocredit/base/types/v1/msg_send.go 95.45% <100.00%> (+0.33%) ⬆️

@aleem1314 aleem1314 marked this pull request as ready for review December 9, 2022 11:00
@aleem1314 aleem1314 requested a review from a team December 9, 2022 11:00
@ryanchristo ryanchristo changed the title fix(ecocredit): don't allow self transfer in MsgSend fix(x/ecocredit): don't allow self transfer in MsgSend Dec 9, 2022
@ryanchristo ryanchristo added the backport/v5.0.x backport to release/v5.0.x branch label Dec 9, 2022
@ryanchristo ryanchristo merged commit 11cb236 into main Dec 9, 2022
@ryanchristo ryanchristo deleted the aleem/fix-msg-send branch December 9, 2022 20:43
mergify bot pushed a commit that referenced this pull request Dec 9, 2022
ryanchristo pushed a commit that referenced this pull request Dec 9, 2022
… (#1675)

Co-authored-by: MD Aleem <72057206+aleem1314@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/v5.0.x backport to release/v5.0.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants