-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(x/ecocredit): add missing transfer event #1667
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1667 +/- ##
==========================================
- Coverage 73.03% 73.03% -0.01%
==========================================
Files 228 228
Lines 13378 13389 +11
==========================================
+ Hits 9771 9779 +8
- Misses 2892 2894 +2
- Partials 715 716 +1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pre-approving, just a couple nits
Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com>
Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com> (cherry picked from commit 5866f67)
Description
Ref: #1660
While auditing buy direct, I noticed we are missing a transfer event. This pull request adds the missing transfer event and also improves comments for the fill order logic used when purchasing credits.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change