Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(x/ecocredit): add missing transfer event #1667

Merged
merged 4 commits into from
Dec 8, 2022

Conversation

ryanchristo
Copy link
Member

Description

Ref: #1660

While auditing buy direct, I noticed we are missing a transfer event. This pull request adds the missing transfer event and also improves comments for the fill order logic used when purchasing credits.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@codecov
Copy link

codecov bot commented Dec 7, 2022

Codecov Report

Merging #1667 (0a0f8e2) into main (728547a) will decrease coverage by 0.00%.
The diff coverage is 88.00%.

❗ Current head 0a0f8e2 differs from pull request most recent head 1e30c30. Consider uploading reports for the commit 1e30c30 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1667      +/-   ##
==========================================
- Coverage   73.03%   73.03%   -0.01%     
==========================================
  Files         228      228              
  Lines       13378    13389      +11     
==========================================
+ Hits         9771     9779       +8     
- Misses       2892     2894       +2     
- Partials      715      716       +1     
Impacted Files Coverage Δ
x/ecocredit/marketplace/keeper/utils.go 49.66% <86.20%> (+6.80%) ⬆️
x/ecocredit/marketplace/keeper/msg_buy_direct.go 78.12% <94.11%> (+1.98%) ⬆️
app/app.go 92.39% <0.00%> (-0.29%) ⬇️

@ryanchristo ryanchristo changed the title fix(x/ecocredit): add missing transfer event and add comments fix(x/ecocredit): add missing transfer event Dec 7, 2022
@ryanchristo ryanchristo marked this pull request as ready for review December 8, 2022 04:39
@ryanchristo ryanchristo requested a review from a team December 8, 2022 04:39
@ryanchristo ryanchristo added the backport/v5.0.x backport to release/v5.0.x branch label Dec 8, 2022
Copy link
Member

@blushi blushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pre-approving, just a couple nits

x/ecocredit/marketplace/keeper/utils.go Outdated Show resolved Hide resolved
x/ecocredit/marketplace/keeper/utils.go Outdated Show resolved Hide resolved
ryanchristo and others added 2 commits December 8, 2022 08:18
@ryanchristo ryanchristo merged commit 5866f67 into main Dec 8, 2022
@ryanchristo ryanchristo deleted the ryan/1660-audit-fill-order branch December 8, 2022 16:36
mergify bot pushed a commit that referenced this pull request Dec 8, 2022
Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com>
(cherry picked from commit 5866f67)
ryanchristo added a commit that referenced this pull request Dec 8, 2022
Co-authored-by: Ryan Christoffersen <12519942+ryanchristo@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/v5.0.x backport to release/v5.0.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants