Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(x/ecocredit): add retirement reason flag #1659

Merged
merged 3 commits into from
Dec 6, 2022
Merged

Conversation

ryanchristo
Copy link
Member

@ryanchristo ryanchristo commented Dec 5, 2022

Description

Ref: https://hackmd.io/vcNbk99BTiWJ4cMtALSBOA

This pull request adds an optional retirement reason flag to all tx commands that support retirement reason.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@ryanchristo ryanchristo added the backport/v5.0.x backport to release/v5.0.x branch label Dec 5, 2022
@ryanchristo
Copy link
Member Author

Manually tested retire, create batch, send, buy, and take from basket using https://hackmd.io/vcNbk99BTiWJ4cMtALSBOA with the current branch rather than the release branch and no issues remaining.

@ryanchristo ryanchristo marked this pull request as ready for review December 5, 2022 23:00
@ryanchristo ryanchristo requested a review from a team December 5, 2022 23:00
@codecov
Copy link

codecov bot commented Dec 5, 2022

Codecov Report

Merging #1659 (8aa0812) into main (7675f73) will decrease coverage by 0.03%.
The diff coverage is 79.31%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1659      +/-   ##
==========================================
- Coverage   73.03%   72.99%   -0.04%     
==========================================
  Files         228      228              
  Lines       13332    13358      +26     
==========================================
+ Hits         9737     9751      +14     
- Misses       2884     2892       +8     
- Partials      711      715       +4     
Impacted Files Coverage Δ
x/ecocredit/base/client/tx.go 80.66% <75.00%> (-0.51%) ⬇️
x/ecocredit/basket/client/tx.go 70.35% <80.00%> (-0.50%) ⬇️
x/ecocredit/marketplace/client/tx.go 86.07% <84.21%> (-1.00%) ⬇️

Copy link
Contributor

@aleem1314 aleem1314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ryanchristo ryanchristo merged commit 750875c into main Dec 6, 2022
@ryanchristo ryanchristo deleted the ryan/add-reason-flag branch December 6, 2022 16:03
mergify bot pushed a commit that referenced this pull request Dec 6, 2022
ryanchristo added a commit that referenced this pull request Dec 6, 2022
Co-authored-by: Ryan Christoffersen <12519942+ryanchristo@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/v5.0.x backport to release/v5.0.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants