Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(x/ecocredit): add query balances by batch cmd #1634

Merged
merged 3 commits into from
Nov 24, 2022

Conversation

ryanchristo
Copy link
Member

Description

Ref: #1456 (https://hackmd.io/vcNbk99BTiWJ4cMtALSBOA?view)

While performing manual tests, I noticed we were missing a command for QueryBalancesByBatch. This adds the missing command and adds a missing test. Also fixes formatting and returning QueryClassIssuersCmd error.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@codecov
Copy link

codecov bot commented Nov 23, 2022

Codecov Report

Merging #1634 (7b03236) into main (6043274) will increase coverage by 0.13%.
The diff coverage is 92.03%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1634      +/-   ##
==========================================
+ Coverage   77.62%   77.76%   +0.13%     
==========================================
  Files         266      266              
  Lines       19484    19579      +95     
==========================================
+ Hits        15125    15225     +100     
+ Misses       3490     3482       -8     
- Partials      869      872       +3     
Impacted Files Coverage Δ
x/ecocredit/client/query.go 0.00% <0.00%> (ø)
x/ecocredit/base/client/query.go 69.34% <82.35%> (+2.60%) ⬆️
x/ecocredit/client/testsuite/query.go 99.56% <100.00%> (+0.03%) ⬆️
x/ecocredit/client/testsuite/suite.go 96.47% <100.00%> (+0.06%) ⬆️

@ryanchristo ryanchristo marked this pull request as ready for review November 23, 2022 19:02
@ryanchristo ryanchristo requested a review from a team November 23, 2022 19:02
@ryanchristo ryanchristo merged commit 6e6cfdb into main Nov 24, 2022
@ryanchristo ryanchristo deleted the ryan/balances-by-batch-cmd branch November 24, 2022 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants