feat(x/ecocredit): add owner to bridge event #1626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1626 +/- ##
=======================================
Coverage 77.62% 77.62%
=======================================
Files 266 266
Lines 19480 19481 +1
=======================================
+ Hits 15121 15122 +1
Misses 3490 3490
Partials 869 869
|
aleem1314
approved these changes
Nov 22, 2022
aaronc
approved these changes
Nov 22, 2022
|
|
||
| // owner is the owner address. | ||
| // | ||
| // Since Revision 1 |
There was a problem hiding this comment.
Revision should be added as a package comment too
There was a problem hiding this comment.
We have a doc.proto file with the comment here. Does that work?
There was a problem hiding this comment.
There was a problem hiding this comment.
I'll open a followup once v4.1.5 is released to update in progress to the latest versions and existing revision 1 comments to revision 2 and in progress (which will then be v5.0).
mergify bot
pushed a commit
that referenced
this pull request
Nov 22, 2022
(cherry picked from commit 9fbf67e) # Conflicts: # CHANGELOG.md # api/regen/ecocredit/v1/events.pulsar.go # x/ecocredit/core/events.pb.go # x/ecocredit/server/core/features/msg_bridge.feature
19 tasks
ryanchristo
added a commit
that referenced
this pull request
Nov 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ref: https://github.com/rnd-inc/toucan-bridge-service/pull/271
This pull request adds
ownertoEventBridgeto simplify the extraction of the sender in the bridge service.Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change