Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ecocredit): return grpc errors in basket and marketplace queries #1588

Merged
merged 4 commits into from
Nov 7, 2022

Conversation

aleem1314
Copy link
Contributor

Description

Ref: #1577


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@codecov
Copy link

codecov bot commented Nov 3, 2022

Codecov Report

Merging #1588 (d8dab26) into main (22beb86) will decrease coverage by 0.00%.
The diff coverage is 34.54%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1588      +/-   ##
==========================================
- Coverage   77.59%   77.58%   -0.01%     
==========================================
  Files         263      263              
  Lines       19244    19265      +21     
==========================================
+ Hits        14932    14947      +15     
- Misses       3449     3453       +4     
- Partials      863      865       +2     
Impacted Files Coverage Δ
x/ecocredit/basket/keeper/query_fees.go 62.50% <0.00%> (ø)
...t/marketplace/keeper/query_sell_orders_by_batch.go 61.70% <14.28%> (-4.21%) ⬇️
.../marketplace/keeper/query_sell_orders_by_seller.go 57.14% <14.28%> (-3.73%) ⬇️
x/ecocredit/basket/keeper/query_baskets.go 53.06% <16.66%> (-3.47%) ⬇️
x/ecocredit/basket/keeper/query_balance.go 66.66% <33.33%> (+12.49%) ⬆️
.../ecocredit/marketplace/keeper/query_sell_orders.go 61.70% <42.85%> (+2.61%) ⬆️
x/ecocredit/basket/keeper/query_balances.go 62.79% <44.44%> (+2.79%) ⬆️
...ocredit/marketplace/keeper/query_allowed_denoms.go 50.00% <60.00%> (+5.55%) ⬆️
x/ecocredit/marketplace/keeper/query_sell_order.go 80.00% <66.66%> (+2.22%) ⬆️
... and 1 more

go.mod Outdated Show resolved Hide resolved
@aleem1314 aleem1314 marked this pull request as ready for review November 3, 2022 09:26
@aleem1314 aleem1314 requested a review from a team November 3, 2022 09:26
Copy link
Member

@ryanchristo ryanchristo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One question/suggestion.

x/ecocredit/basket/keeper/query_fees.go Outdated Show resolved Hide resolved
Copy link
Contributor

@technicallyty technicallyty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - preapproving, pending Ryan's suggestion

Co-authored-by: Ryan Christoffersen <12519942+ryanchristo@users.noreply.github.com>
@ryanchristo ryanchristo merged commit e06a36b into main Nov 7, 2022
@ryanchristo ryanchristo deleted the aleem/ecocredit-basket-query branch November 7, 2022 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants