-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update to cosmos-sdk v0.45.9 #1549
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should merge this into master too right?
Sure we can |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to upgrade our fork of v0.45 I think, instead of just bumping here.
@@ -4,7 +4,7 @@ go 1.18 | |||
|
|||
require ( | |||
github.com/CosmWasm/wasmd v0.22.0 | |||
github.com/cosmos/cosmos-sdk v0.45.4 | |||
github.com/cosmos/cosmos-sdk v0.45.9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it okay to not update our SDK fork? We are using SDK forked version.
I'm updating our fork, will update here when that's done so we can update this PR accordingly. |
Updated to the tag on our fork. Can you re-review @clevinson ? |
go.mod
Outdated
@@ -148,7 +151,7 @@ replace google.golang.org/grpc => google.golang.org/grpc v1.33.2 | |||
|
|||
replace github.com/gogo/protobuf => github.com/regen-network/protobuf v1.3.3-alpha.regen.1 | |||
|
|||
replace github.com/cosmos/cosmos-sdk => github.com/regen-network/cosmos-sdk v0.45.0-regen-1 | |||
replace github.com/cosmos/cosmos-sdk => github.com/regen-network/cosmos-sdk v0.45.9-regen-1 | |||
|
|||
replace github.com/tendermint/tendermint => github.com/tendermint/tendermint v0.34.14 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Build failing because of this line. Why do we need it?
Description
Closes: #XXXX
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change