Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update to cosmos-sdk v0.45.9 #1549

Merged
merged 4 commits into from
Oct 14, 2022
Merged

Conversation

aaronc
Copy link
Member

@aaronc aaronc commented Oct 14, 2022

Description

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

Copy link
Contributor

@anilcse anilcse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should merge this into master too right?

@aaronc aaronc enabled auto-merge (squash) October 14, 2022 15:28
@aaronc
Copy link
Member Author

aaronc commented Oct 14, 2022

We should merge this into master too right?

Sure we can

Copy link
Member

@clevinson clevinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to upgrade our fork of v0.45 I think, instead of just bumping here.

@@ -4,7 +4,7 @@ go 1.18

require (
github.com/CosmWasm/wasmd v0.22.0
github.com/cosmos/cosmos-sdk v0.45.4
github.com/cosmos/cosmos-sdk v0.45.9
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it okay to not update our SDK fork? We are using SDK forked version.

@clevinson
Copy link
Member

I'm updating our fork, will update here when that's done so we can update this PR accordingly.

@aaronc
Copy link
Member Author

aaronc commented Oct 14, 2022

Updated to the tag on our fork. Can you re-review @clevinson ?

@aaronc aaronc requested a review from clevinson October 14, 2022 16:37
go.mod Show resolved Hide resolved
go.mod Outdated
@@ -148,7 +151,7 @@ replace google.golang.org/grpc => google.golang.org/grpc v1.33.2

replace github.com/gogo/protobuf => github.com/regen-network/protobuf v1.3.3-alpha.regen.1

replace github.com/cosmos/cosmos-sdk => github.com/regen-network/cosmos-sdk v0.45.0-regen-1
replace github.com/cosmos/cosmos-sdk => github.com/regen-network/cosmos-sdk v0.45.9-regen-1

replace github.com/tendermint/tendermint => github.com/tendermint/tendermint v0.34.14
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build failing because of this line. Why do we need it?

@aaronc aaronc disabled auto-merge October 14, 2022 18:29
@aaronc aaronc merged commit c11a317 into release/v4.1.x Oct 14, 2022
@aaronc aaronc deleted the aaronc/dragonberry branch October 14, 2022 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants