Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(app)!: use built-in cobra completion #1546

Merged
merged 3 commits into from
Oct 19, 2022

Conversation

aaronc
Copy link
Member

@aaronc aaronc commented Oct 13, 2022

Description

This will provide a better dev UX, see also: cosmos/cosmos-sdk#13548. Cobra has its own completion command which is better than this old tmcli command.

Also, let's do this: https://carlosbecker.com/posts/golang-completions-cobra/


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@aaronc aaronc requested a review from a team October 13, 2022 23:33
Copy link
Member

@ryanchristo ryanchristo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pre-approving. Can you add a changelog entry? 🙏

@codecov
Copy link

codecov bot commented Oct 19, 2022

Codecov Report

Merging #1546 (6b97cd1) into main (ac275f1) will decrease coverage by 0.25%.
The diff coverage is n/a.

❗ Current head 6b97cd1 differs from pull request most recent head 99e3943. Consider uploading reports for the commit 99e3943 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1546      +/-   ##
==========================================
- Coverage   78.69%   78.43%   -0.26%     
==========================================
  Files         251      251              
  Lines       18851    18855       +4     
==========================================
- Hits        14834    14789      -45     
- Misses       3153     3201      +48     
- Partials      864      865       +1     
Impacted Files Coverage Δ
app/client/cli/root.go 61.26% <ø> (-0.18%) ⬇️
...edit/base/types/v1/msg_add_allowed_bridge_chain.go 0.00% <0.00%> (-66.67%) ⬇️
...t/base/types/v1/msg_set_class_creator_allowlist.go 41.66% <0.00%> (-16.67%) ⬇️
...cocredit/base/types/v1/msg_remove_class_creator.go 46.15% <0.00%> (-15.39%) ⬇️
x/ecocredit/base/types/v1/msg_seal_batch.go 53.33% <0.00%> (-13.34%) ⬇️
x/ecocredit/base/types/v1/msg_add_class_creator.go 53.33% <0.00%> (-13.34%) ⬇️
...t/base/types/v1/msg_remove_allowed_bridge_chain.go 53.33% <0.00%> (-13.34%) ⬇️
x/data/msg_anchor.go 80.00% <0.00%> (-13.34%) ⬇️
x/data/msg_define_resolver.go 80.00% <0.00%> (-13.34%) ⬇️
x/ecocredit/base/types/v1/msg_update_class_fee.go 56.25% <0.00%> (-12.50%) ⬇️
... and 19 more

@ryanchristo ryanchristo changed the title feat!: use built-in cobra completion feat(app)!: use built-in cobra completion Oct 19, 2022
@ryanchristo ryanchristo merged commit 37dbe9f into main Oct 19, 2022
@ryanchristo ryanchristo deleted the aaronc/use-cobra-completion branch October 19, 2022 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants