Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix valset upgrade #1533

Merged
merged 5 commits into from
Oct 7, 2022
Merged

Conversation

aleem1314
Copy link
Contributor

Description

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@aleem1314 aleem1314 marked this pull request as ready for review October 7, 2022 17:11
Copy link
Contributor

@anilcse anilcse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@technicallyty technicallyty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Copy link
Member

@aaronc aaronc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like we should be checking validatorsVoteInfos which actually comes from tendermint

@aleem1314
Copy link
Contributor Author

aleem1314 commented Oct 7, 2022

It seems like we should be checking validatorsVoteInfos which actually comes from tendermint

Updated. I think those two maps will be the same. We hard-coded pubkeys from tendermint RPC.

@aleem1314 aleem1314 requested a review from aaronc October 7, 2022 18:19
@aaronc
Copy link
Member

aaronc commented Oct 7, 2022

Probably both will work but this seems more correct. Can you test and verify?

@anilcse
Copy link
Contributor

anilcse commented Oct 7, 2022

Probably both will work but this seems more correct. Can you test and verify?

Yeah, both should work. @kaustubhkapatral just tested this update too. It's working fine

Copy link
Member

@aaronc aaronc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@technicallyty technicallyty merged commit 1d4e554 into release/v4.1.x Oct 7, 2022
@technicallyty technicallyty deleted the aleem/testing-upgrade-issue branch October 7, 2022 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants