Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Run buf mod update #1479

Merged
merged 4 commits into from
Sep 15, 2022
Merged

chore: Run buf mod update #1479

merged 4 commits into from
Sep 15, 2022

Conversation

stefanvanburen
Copy link
Contributor

Description

This also:

  • Removes the vendored cosmos/msg/v1/msg.proto in favor of the hosted one, which has the same content.
  • Adjusts the imports for cosmos.orm to reference v1 instead of v1alpha1, which was moved.

Let me know if there's anything else I need to do to get this merged!

Closes: #1478


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

This also:

* Removes the vendored `cosmos/msg/v1/msg.proto` in favor of the hosted
  one, which [has the same content](https://github.com/cosmos/cosmos-sdk/blob/main/proto/cosmos/msg/v1/msg.proto)
* Adjusts the imports for cosmos.orm to reference `v1` instead of
  `v1alpha1`, which [was
  moved](cosmos/cosmos-sdk@462d017).
@stefanvanburen stefanvanburen requested a review from a team September 7, 2022 14:06
@stefanvanburen stefanvanburen changed the title Run buf mod update chore: Run buf mod update Sep 7, 2022
@technicallyty
Copy link
Contributor

awesome, thanks for submitting this PR! ❤️

@technicallyty
Copy link
Contributor

hey @stefanvanburen was wondering if you could provide any insight on an issue we are facing. our actions are failing with this message: Failure: buf.build/cosmos/cosmos-sdk:af8d763f189a4482b59f9f283b446293: does not exist.

however, this commit does exist on buf.build - https://buf.build/cosmos/cosmos-sdk/commits/af8d763f189a4482b59f9f283b446293

clicking on the commit causes a 404 though. additionally, all of our old commits on buf.build/cosmos/cosmos-sdk seem to have the same 404 issue. only new commits appear to show the proper assets.

I'm curious if maybe theres some sort of caching problem happening. If you have any insight here i would greatly appreciate it 🙏🏻

@ryanchristo
Copy link
Member

Thank you @stefanvanburen! ❤️

hey @stefanvanburen was wondering if you could provide any insight on an issue we are facing. our actions are failing with this message: Failure: buf.build/cosmos/cosmos-sdk:af8d763f189a4482b59f9f283b446293: does not exist.

Let's sort out in a followup. I think this is related to the action itself.

@ryanchristo ryanchristo merged commit 16c2938 into regen-network:main Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update buf.lock references
4 participants