Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(x/ecocredit): clean up legacy params #1476

Merged
merged 8 commits into from
Sep 14, 2022
Merged

Conversation

aleem1314
Copy link
Contributor

Description

cleans up legacy params usage in ecocredit module

Closes: n/a


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@codecov
Copy link

codecov bot commented Sep 7, 2022

Codecov Report

Merging #1476 (c9ce7e8) into main (ec9f38b) will increase coverage by 0.06%.
The diff coverage is 100.00%.

❗ Current head c9ce7e8 differs from pull request most recent head abe62c5. Consider uploading reports for the commit abe62c5 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1476      +/-   ##
==========================================
+ Coverage   78.28%   78.35%   +0.06%     
==========================================
  Files         248      248              
  Lines       18710    18630      -80     
==========================================
- Hits        14648    14597      -51     
+ Misses       3196     3181      -15     
+ Partials      866      852      -14     
Impacted Files Coverage Δ
x/ecocredit/genesis/default.go 100.00% <ø> (ø)
x/ecocredit/server/genesis.go 47.05% <ø> (-6.79%) ⬇️
x/ecocredit/client/testsuite/query.go 99.52% <100.00%> (+<0.01%) ⬆️
x/ecocredit/client/testsuite/suite.go 96.40% <100.00%> (-0.06%) ⬇️
x/ecocredit/genesis/genesis.go 48.26% <100.00%> (+0.04%) ⬆️
x/ecocredit/module/module.go 55.31% <100.00%> (+8.46%) ⬆️
x/ecocredit/base/types/v1/params.go 13.84% <0.00%> (-29.24%) ⬇️
x/ecocredit/base/types/v1/codec.go 100.00% <0.00%> (ø)
x/ecocredit/basket/types/v1/codec.go 100.00% <0.00%> (ø)
x/ecocredit/base/types/v1/msg_send.go 94.73% <0.00%> (ø)
... and 24 more

@aleem1314 aleem1314 marked this pull request as ready for review September 7, 2022 13:46
@aleem1314 aleem1314 requested a review from a team September 7, 2022 13:46
Copy link
Contributor

@technicallyty technicallyty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Tyler <48813565+technicallyty@users.noreply.github.com>
@ryanchristo ryanchristo changed the title refactor(ecocredit): cleanup legacy params refactor(x/ecocredit): clean up legacy params Sep 14, 2022
Copy link
Member

@ryanchristo ryanchristo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

x/ecocredit/module/module_test.go Outdated Show resolved Hide resolved
@ryanchristo ryanchristo merged commit 5c80df5 into main Sep 14, 2022
@ryanchristo ryanchristo deleted the aleem/cleanup-params branch September 14, 2022 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants