-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(x/ecocredit)!: gov approved bridge chains #1462
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! This looks great. A couple questions/suggestions. Will manually test.
x/ecocredit/base/keeper/features/msg_add_allowed_bridge_chain.feature
Outdated
Show resolved
Hide resolved
x/ecocredit/base/keeper/msg_remove_allowed_bridge_chain_test.go
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## main #1462 +/- ##
==========================================
- Coverage 78.42% 78.21% -0.21%
==========================================
Files 238 243 +5
Lines 18513 18626 +113
==========================================
+ Hits 14518 14568 +50
- Misses 3150 3206 +56
- Partials 845 852 +7
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description
AllowedBridgeChains
AddAllowedBridgeChain
andRemoveAllowedBridgeChain
AllowedBridgeChains
tableI assume the bridge service will be live and running by the next upgrade, so went ahead and initialized the table with
POLYGON
in the migration. If thats not a correct assumption, I will remove itCloses: #1119
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change