refactor(x/ecocredit): rename ecocredit core functionality to base

[ryanchristo]

Description

Ref: #1196, #1429

Finish renaming core to base following #1429.

---

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

• included the correct type prefix in the PR title
• added ! to the type prefix if API or client breaking change
• targeted the correct branch (see PR Targeting)
• provided a link to the relevant issue or specification
• followed the guidelines for building modules
• included the necessary unit and integration tests
• added a changelog entry to CHANGELOG.md
• included comments for documenting Go code
• updated the relevant documentation or specification
• reviewed "Files changed" and left comments if necessary
• confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

• confirmed the correct type prefix in the PR title
• confirmed ! in the type prefix if API or client breaking change
• confirmed all author checklist items have been addressed
• reviewed state machine logic
• reviewed API design and naming
• reviewed documentation is accurate
• reviewed tests and test coverage
• manually tested (if applicable)

[codecov]

Codecov Report

Merging #1447 (c8ea895) into main (4ef8001) will decrease coverage by 0.02%.
The diff coverage is 78.23%.

@@            Coverage Diff             @@
##             main    #1447      +/-   ##
==========================================
- Coverage   78.48%   78.45%   -0.03%     
==========================================
  Files         238      238              
  Lines       18439    18448       +9     
==========================================
+ Hits        14471    14473       +2     
- Misses       3126     3130       +4     
- Partials      842      845       +3     

Impacted Files	Coverage Δ
x/ecocredit/base/keeper/keeper.go	100.00% <ø> (ø)
x/ecocredit/genesis/genesis.go	41.19% <ø> (ø)
x/ecocredit/server/migrations.go	41.66% <0.00%> (ø)
x/ecocredit/basket/keeper/msg_take.go	59.09% <40.00%> (ø)
x/ecocredit/marketplace/keeper/utils.go	42.40% <50.00%> (ø)
x/ecocredit/module/module.go	54.36% <51.56%> (-2.07%)	⬇️
x/ecocredit/basket/keeper/msg_put.go	65.47% <80.00%> (ø)
x/ecocredit/server/server.go	61.90% <80.00%> (ø)
app/app.go	92.68% <100.00%> (ø)
x/ecocredit/base/keeper/msg_cancel.go	60.86% <100.00%> (ø)
... and 26 more

[technicallyty]

pre-approving

found a few lingerings of "core":

• variable name coreQuerier should now be baseQuerier https://github.com/regen-network/regen-ledger/blob/ryan/rename-core-to-base/x/ecocredit/module/module.go#L269
• comment ecocredit core should now be ecocredit base https://github.com/regen-network/regen-ledger/blob/ryan/rename-core-to-base/x/ecocredit/genesis/genesis.go#L250
• varable name coreQryClient should now be baseQryClient https://github.com/regen-network/regen-ledger/blob/ryan/rename-core-to-base/x/ecocredit/marketplace/simulation/operations.go#L271
• theres a few gas iteration descriptions that still path to "core" in msg server functions create_class, retire, send, update_class_issuers, marketplace.sell
• all our codecs still register the types with regen.core, but i am unsure if that should change/could cause problems? 🤔 do you have any insight on that?

not sure if all of these should be addressed here, but figured i'd point em out just in case 👍🏻

[ryanchristo]

all our codecs still register the types with regen.core, but i am unsure if that should change/could cause problems? thinking do you have any insight on that?

As far as I can tell, this should be ok to update. Might require a change for app developers so added a changelog entry for this specifically. This should probably not have been regen.core/... in the first place but rather regen/... to align with the type urls and proto package structure. I removed core from gas iterations rather than updating them to base for the same reason (and fixed the reference in the marketplace sell method).

[aleem1314]

lgtm