Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(types): add default page limit #1433

Merged
merged 6 commits into from
Aug 30, 2022
Merged

Conversation

technicallyty
Copy link
Contributor

@technicallyty technicallyty commented Aug 30, 2022

Description

  • adds a default page limit in the absence of a page request.

Closes: #1432


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@technicallyty technicallyty marked this pull request as ready for review August 30, 2022 00:13
@technicallyty technicallyty requested a review from a team August 30, 2022 00:13
@codecov
Copy link

codecov bot commented Aug 30, 2022

Codecov Report

Merging #1433 (15f04f7) into main (9c6ecef) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 15f04f7 differs from pull request most recent head ce4825c. Consider uploading reports for the commit ce4825c to get more accurate results

@@            Coverage Diff             @@
##             main    #1433      +/-   ##
==========================================
- Coverage   78.58%   78.57%   -0.01%     
==========================================
  Files         236      235       -1     
  Lines       18127    18051      -76     
==========================================
- Hits        14245    14184      -61     
+ Misses       3074     3064      -10     
+ Partials      808      803       -5     
Impacted Files Coverage Δ
x/data/client/testsuite/grpc.go 100.00% <ø> (ø)
x/ecocredit/client/testsuite/grpc.go 100.00% <ø> (ø)
types/ormutil/compatability.go 58.62% <100.00%> (-10.35%) ⬇️
x/ecocredit/server/core/query_all_balances.go

Copy link
Member

@ryanchristo ryanchristo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think this is a feature though as it does not improve performance.

@ryanchristo ryanchristo changed the title perf(types): add default page limit feat(types): add default page limit Aug 30, 2022
@ryanchristo ryanchristo merged commit 7652f47 into main Aug 30, 2022
@ryanchristo ryanchristo deleted the ty/1432-default_page_request branch August 30, 2022 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add default pagination to queries that could return large responses
2 participants