Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(x/ecocredit): add event for removing allowed denom in marketplace #1412

Merged
merged 5 commits into from
Aug 25, 2022

Conversation

technicallyty
Copy link
Contributor

@technicallyty technicallyty commented Aug 25, 2022

Description

  • adds an event for removing an allowed denom in the marketplace

Closes: #1409


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@technicallyty technicallyty marked this pull request as ready for review August 25, 2022 03:01
@technicallyty technicallyty requested a review from a team August 25, 2022 03:01
@codecov
Copy link

codecov bot commented Aug 25, 2022

Codecov Report

❗ No coverage uploaded for pull request base (main@356ec9c). Click here to learn what that means.
The diff coverage is 25.00%.

❗ Current head ae9a727 differs from pull request most recent head b2565ad. Consider uploading reports for the commit b2565ad to get more accurate results

@@           Coverage Diff           @@
##             main    #1412   +/-   ##
=======================================
  Coverage        ?   75.31%           
=======================================
  Files           ?      223           
  Lines           ?    20833           
  Branches        ?        0           
=======================================
  Hits            ?    15690           
  Misses          ?     4187           
  Partials        ?      956           
Impacted Files Coverage Δ
...dit/server/marketplace/msg_remove_allowed_denom.go 61.11% <25.00%> (ø)

technicallyty and others added 2 commits August 25, 2022 08:04
Co-authored-by: MD Aleem <72057206+aleem1314@users.noreply.github.com>
@ryanchristo
Copy link
Member

changelog entry 🙏

Copy link
Member

@ryanchristo ryanchristo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ryanchristo ryanchristo merged commit cf16e04 into main Aug 25, 2022
@ryanchristo ryanchristo deleted the ty/1409-remove_allowed_denom_event branch August 25, 2022 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Emit event for RemoveAllowedDenom
3 participants