Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(x/ecocredit): replace blank event values with actual values #1411

Merged
merged 4 commits into from
Aug 25, 2022

Conversation

technicallyty
Copy link
Contributor

@technicallyty technicallyty commented Aug 24, 2022

Description

replaces values in events that were previously empty strings "", to the dec zero value "0".

Closes: #1333


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@ryanchristo ryanchristo changed the title fix(x/ecocredit/core): replace blank event values with actual values fix(x/ecocredit): replace blank event values with actual values Aug 24, 2022
@codecov
Copy link

codecov bot commented Aug 25, 2022

Codecov Report

❗ No coverage uploaded for pull request base (main@cf16e04). Click here to learn what that means.
The diff coverage is 85.71%.

❗ Current head 681c82a differs from pull request most recent head bcbe387. Consider uploading reports for the commit bcbe387 to get more accurate results

@@           Coverage Diff           @@
##             main    #1411   +/-   ##
=======================================
  Coverage        ?   75.32%           
=======================================
  Files           ?      223           
  Lines           ?    20830           
  Branches        ?        0           
=======================================
  Hits            ?    15690           
  Misses          ?     4185           
  Partials        ?      955           
Impacted Files Coverage Δ
x/ecocredit/server/core/msg_send.go 69.17% <76.92%> (ø)
x/ecocredit/server/core/msg_create_batch.go 66.32% <100.00%> (ø)
x/ecocredit/server/core/msg_mint_batch_credits.go 56.00% <100.00%> (ø)

@technicallyty technicallyty marked this pull request as ready for review August 25, 2022 01:55
@technicallyty technicallyty requested a review from a team August 25, 2022 01:55
@ryanchristo
Copy link
Member

small fix but changelog entry would be nice 🙏

Copy link
Member

@ryanchristo ryanchristo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ryanchristo ryanchristo merged commit 8855cba into main Aug 25, 2022
@ryanchristo ryanchristo deleted the ty/1333-add_missing_event_values branch August 25, 2022 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix ecocredit event values when no value is provided
3 participants