Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(x/ecocredit): add basket fees query #1391

Merged
merged 9 commits into from
Aug 25, 2022
Merged

Conversation

aleem1314
Copy link
Contributor

@aleem1314 aleem1314 commented Aug 23, 2022

Description

Closes: #1363


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@codecov
Copy link

codecov bot commented Aug 23, 2022

Codecov Report

Merging #1391 (71fa41f) into main (5f0185e) will decrease coverage by 0.42%.
The diff coverage is 83.52%.

❗ Current head 71fa41f differs from pull request most recent head e05a435. Consider uploading reports for the commit e05a435 to get more accurate results

@@            Coverage Diff             @@
##             main    #1391      +/-   ##
==========================================
- Coverage   75.24%   74.82%   -0.43%     
==========================================
  Files         218      225       +7     
  Lines       20674    21395     +721     
==========================================
+ Hits        15557    16009     +452     
- Misses       4169     4396     +227     
- Partials      948      990      +42     
Impacted Files Coverage Δ
x/data/server/server.go 57.89% <ø> (ø)
x/ecocredit/basket/types_date_criteria.go 96.87% <ø> (ø)
x/ecocredit/server/core/query_batch_info.go 76.92% <0.00%> (ø)
x/ecocredit/server/server.go 64.10% <ø> (ø)
x/ecocredit/genesis/genesis.go 42.34% <21.05%> (-2.60%) ⬇️
x/ecocredit/server/basket/query_fees.go 53.84% <53.84%> (ø)
x/ecocredit/marketplace/msg_add_allowed_denom.go 66.66% <55.55%> (+5.55%) ⬆️
x/ecocredit/basket/msg_take.go 86.84% <66.66%> (-0.97%) ⬇️
x/ecocredit/client/basket/query.go 72.51% <73.91%> (+0.29%) ⬆️
types/coin.go 51.95% <75.00%> (ø)
... and 48 more

@aleem1314 aleem1314 changed the title feat(x/ecocreidt): add basket fees query feat(x/ecocredit): add basket fees query Aug 24, 2022
@aleem1314 aleem1314 marked this pull request as ready for review August 24, 2022 09:32
@aleem1314 aleem1314 requested a review from a team August 24, 2022 09:32
Copy link
Contributor

@technicallyty technicallyty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

types/coin.go Outdated Show resolved Hide resolved
Copy link
Member

@ryanchristo ryanchristo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ryanchristo ryanchristo merged commit 900d0f1 into main Aug 25, 2022
@ryanchristo ryanchristo deleted the aleem/1363-basket-params branch August 25, 2022 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add query for new basket fees ORM param
3 participants