fix(x/ecocredit): register ecocredit v1alpha1 messages #1360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
83bf5a4 to
35b206b
Compare
aleem1314
reviewed
Aug 18, 2022
| proto.RegisterType((*Params)(nil), "regen.ecocredit.v1alpha1.Params") | ||
| proto.RegisterType((*CreditType)(nil), "regen.ecocredit.v1alpha1.CreditType") | ||
| proto.RegisterType((*CreditTypeSeq)(nil), "regen.ecocredit.v1alpha1.CreditTypeSeq") | ||
| //proto.RegisterType((*ClassInfo)(nil), "regen.ecocredit.v1alpha1.ClassInfo") |
There was a problem hiding this comment.
Why these lines commented?
There was a problem hiding this comment.
We register the types here: #1360 (comment)
ryanchristo
commented
Aug 18, 2022
Comment on lines
+469
to
+473
| proto.RegisterType((*ClassInfo)(nil), "regen.ecocredit.v1alpha1.ClassInfo") | ||
| proto.RegisterType((*BatchInfo)(nil), "regen.ecocredit.v1alpha1.BatchInfo") | ||
| proto.RegisterType((*Params)(nil), "regen.ecocredit.v1alpha1.Params") | ||
| proto.RegisterType((*CreditType)(nil), "regen.ecocredit.v1alpha1.CreditType") | ||
| proto.RegisterType((*CreditTypeSeq)(nil), "regen.ecocredit.v1alpha1.CreditTypeSeq") |
There was a problem hiding this comment.
Answering the above question, the types are registered here.
191d5c0 to
5ed8dbe
Compare
mergify bot
pushed a commit
that referenced
this pull request
Aug 18, 2022
* fix(x/ecocredit): register ecocredit v1alpha1 messages * remove ecocredit v2 replace directive (cherry picked from commit 05c29d1) # Conflicts: # CHANGELOG.md # x/ecocredit/module/module.go
|
Lint passed here but failed on master 🤔 https://github.com/regen-network/regen-ledger/runs/7905079611?check_suite_focus=true |
ryanchristo
added a commit
that referenced
this pull request
Aug 18, 2022
… (#1364) * fix(x/ecocredit): register ecocredit v1alpha1 messages (#1360) * fix(x/ecocredit): register ecocredit v1alpha1 messages * remove ecocredit v2 replace directive (cherry picked from commit 05c29d1) # Conflicts: # CHANGELOG.md # x/ecocredit/module/module.go * release branch revisions Co-authored-by: Ryan Christoffersen <12519942+ryanchristo@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #1356
This pull request registers ecocredit v1alpha1 messages to allow for historical events to be queried.
The proto break check is failing although this is not a proto breaking change, only the file option was updated. Implementing the messages any further does not seem necessary given we do not register the messages to the msg server. This should qualify for a point release, no API or state machine breaking changes, but let me know if there are any concerns.
Manual Test: https://hackmd.io/USRbzfq1QwSn2oJcXwQ3Xg
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change