Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move cmd to root and client to app #1350

Merged
merged 2 commits into from
Aug 15, 2022
Merged

Conversation

ryanchristo
Copy link
Member

@ryanchristo ryanchristo commented Aug 15, 2022

Description

This pull request moves the entry point for the regen application to cmd/regen to align with go conventions. This pull request also moves client/docs to app/client/docs and updates swagger to use the new location and ibc-go v5.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@ryanchristo ryanchristo marked this pull request as ready for review August 15, 2022 15:00
@ryanchristo ryanchristo requested a review from a team August 15, 2022 15:00
@codecov
Copy link

codecov bot commented Aug 15, 2022

Codecov Report

Merging #1350 (5133f84) into master (9aef28b) will increase coverage by 0.03%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #1350      +/-   ##
==========================================
+ Coverage   77.36%   77.40%   +0.03%     
==========================================
  Files         211      211              
  Lines       15395    15395              
==========================================
+ Hits        11910    11916       +6     
+ Misses       2582     2576       -6     
  Partials      903      903              
Impacted Files Coverage Δ
app/app.go 73.55% <0.00%> (ø)
app/client/cli/genaccounts.go 15.15% <ø> (ø)
app/client/cli/root.go 58.10% <ø> (ø)
app/client/cli/testnet.go 16.79% <ø> (ø)
types/context.go 76.38% <0.00%> (+4.16%) ⬆️

Copy link
Contributor

@technicallyty technicallyty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@ryanchristo ryanchristo merged commit 52fa7cb into master Aug 15, 2022
@ryanchristo ryanchristo deleted the ryan/cmd-convention branch August 15, 2022 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants