-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(x/ecocredit)!: migrate add-allow-denom proposal to msg based proposal #1342
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1342 +/- ##
=========================================
Coverage ? 77.40%
=========================================
Files ? 211
Lines ? 15395
Branches ? 0
=========================================
Hits ? 11916
Misses ? 2576
Partials ? 903
|
@@ -5,9 +5,6 @@ package regen.ecocredit.marketplace.v1; | |||
import "gogoproto/gogo.proto"; | |||
import "regen/ecocredit/marketplace/v1/state.proto"; | |||
|
|||
option go_package = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are not using AllowDenomProposal
message. Removing this line is breaking buf-lint
check.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, 2 tiny nits
x/ecocredit/server/marketplace/features/msg_add_allowed_denom.feature
Outdated
Show resolved
Hide resolved
Co-authored-by: Tyler <48813565+technicallyty@users.noreply.github.com>
…feature Co-authored-by: Tyler <48813565+technicallyty@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Each file within a proto package must have the same go package option. Even though we don't need the generated code for the proposal in marketplace types, we need to keep the go package option.
|
Description
Closes: #XXXX
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change