Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(app)!: add group module #1340

Merged
merged 9 commits into from
Aug 11, 2022
Merged

feat(app)!: add group module #1340

merged 9 commits into from
Aug 11, 2022

Conversation

aleem1314
Copy link
Contributor

@aleem1314 aleem1314 commented Aug 8, 2022

Description

Closes: #378


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@@ -360,6 +366,9 @@ func NewRegenApp(logger log.Logger, db dbm.DB, traceStore io.Writer, loadLatest
)
app.AuthzKeeper = authzKeeper

groupConfig := group.DefaultConfig()
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

group module default-config.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Defaults look good to me.

@aleem1314 aleem1314 marked this pull request as ready for review August 10, 2022 05:46
Copy link
Member

@ryanchristo ryanchristo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. One question about the added migration test.

CHANGELOG.md Show resolved Hide resolved
app/app_test.go Outdated Show resolved Hide resolved
@aleem1314 aleem1314 requested a review from a team August 11, 2022 05:24
@codecov
Copy link

codecov bot commented Aug 11, 2022

Codecov Report

Merging #1340 (a3c33fc) into master (682e4de) will decrease coverage by 0.32%.
The diff coverage is 62.97%.

❗ Current head a3c33fc differs from pull request most recent head 7b32cc6. Consider uploading reports for the commit 7b32cc6 to get more accurate results

@@            Coverage Diff             @@
##           master    #1340      +/-   ##
==========================================
- Coverage   77.45%   77.12%   -0.33%     
==========================================
  Files         221      213       -8     
  Lines       16120    15464     -656     
==========================================
- Hits        12486    11927     -559     
- Misses       2620     2625       +5     
+ Partials     1014      912     -102     
Flag Coverage Δ
experimental-codecov ?
stable-codecov ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
app/export.go 10.20% <0.00%> (+0.40%) ⬆️
app/regen/cmd/genaccounts.go 15.15% <0.00%> (-0.98%) ⬇️
app/regen/cmd/testnet.go 16.79% <0.00%> (ø)
types/module/server/root_module_key.go 11.76% <ø> (+5.88%) ⬆️
x/data/client/testsuite/grpc.go 100.00% <ø> (ø)
x/data/msg_anchor.go 80.00% <ø> (ø)
x/data/msg_attest.go 60.00% <ø> (ø)
x/data/msg_define_resolver.go 80.00% <ø> (ø)
x/data/msg_register_resolver.go 81.81% <ø> (ø)
x/data/server/server.go 71.42% <ø> (ø)
... and 62 more

Copy link
Member

@ryanchristo ryanchristo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@technicallyty technicallyty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ryanchristo ryanchristo merged commit 073b1e4 into master Aug 11, 2022
@ryanchristo ryanchristo deleted the aleem/378-group-module branch August 11, 2022 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Group Module (SDK Integration)
3 participants