feat(x/ecocredit)!: migrate add-credit-type proposal to msg based proposal

[aleem1314]

Description

Closes: #XXXX

---

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

• included the correct type prefix in the PR title
• added ! to the type prefix if API or client breaking change
• targeted the correct branch (see PR Targeting)
• provided a link to the relevant issue or specification
• followed the guidelines for building modules
• included the necessary unit and integration tests
• added a changelog entry to CHANGELOG.md
• included comments for documenting Go code
• updated the relevant documentation or specification
• reviewed "Files changed" and left comments if necessary
• confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

• confirmed the correct type prefix in the PR title
• confirmed ! in the type prefix if API or client breaking change
• confirmed all author checklist items have been addressed
• reviewed state machine logic
• reviewed API design and naming
• reviewed documentation is accurate
• reviewed tests and test coverage
• manually tested (if applicable)

[ryanchristo]

Looking good although I think we should only allow adding one credit type at a time. This would make the implementation a bit simpler. cc @clevinson thoughts?

[ryanchristo]

Looking good. My bad for not generating proto after making formatting fixes in #721. Mostly small nits from me. Nice work taking on writing feature files!

[codecov]

Codecov Report

❗ No coverage uploaded for pull request base (master@5a9732a). Click here to learn what that means.
The diff coverage is 75.00%.

❗ Current head 2400513 differs from pull request most recent head 2abbbf1. Consider uploading reports for the commit 2abbbf1 to get more accurate results

@@            Coverage Diff            @@
##             master    #1337   +/-   ##
=========================================
  Coverage          ?   77.11%           
=========================================
  Files             ?      213           
  Lines             ?    15420           
  Branches          ?        0           
=========================================
  Hits              ?    11891           
  Misses            ?     2621           
  Partials          ?      908           

Impacted Files	Coverage Δ
app/stable_appconfig.go	93.54% <ø> (ø)
x/ecocredit/server/proposal.go	100.00% <ø> (ø)
x/ecocredit/core/msg_add_credit_type.go	50.00% <50.00%> (ø)
x/ecocredit/server/core/msg_add_credit_type.go	73.33% <73.33%> (ø)
app/app.go	72.99% <100.00%> (ø)
x/ecocredit/core/codec.go	100.00% <100.00%> (ø)
x/ecocredit/module/module.go	58.33% <100.00%> (ø)
x/ecocredit/server/core/keeper.go	100.00% <100.00%> (ø)
x/ecocredit/server/server.go	73.91% <100.00%> (ø)
x/ecocredit/server/tests/utils.go	100.00% <100.00%> (ø)

[ryanchristo]

tACK. Nice work on adding gherkin/gocuke tests.

[technicallyty]

LGTM 👍🏻