-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(types): return nil duration and timestamp #1292
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1292 +/- ##
==========================================
+ Coverage 77.51% 77.58% +0.07%
==========================================
Files 213 213
Lines 16084 16084
==========================================
+ Hits 12467 12479 +12
+ Misses 2613 2597 -16
- Partials 1004 1008 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
technicallyty
approved these changes
Jul 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
aleem1314
approved these changes
Jul 22, 2022
mergify bot
pushed a commit
that referenced
this pull request
Jul 22, 2022
* fix(types): return nil duration and timestamp * update query sell order test with nil check * add changelog (cherry picked from commit 727d41a)
ryanchristo
added a commit
that referenced
this pull request
Jul 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #1272
Manual tests: https://hackmd.io/ioZPdD22REaHBE1YQg1YPg
This pull request updates timestamp conversion functions to return
nil
if timestamp or duration isnil
rather than returning the zero-value timestamp and duration. This only affects query responses where a timestamp or duration is used and where these values are not required when being added to state (e.g. sell order expiration). This will also usenil
rather than the zero-value timestamp for issuance date when querying batches if a batch is added between now and the upgrade.For example, a sell order with no expiration previously returned:
Now, a sell order with no expiration returns:
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change