fix(x/ecocredit): fix core message validation and update tests #1233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1233 +/- ##
==========================================
+ Coverage 79.65% 79.76% +0.11%
==========================================
Files 230 231 +1
Lines 21444 21476 +32
==========================================
+ Hits 17081 17131 +50
- Misses 3007 3008 +1
+ Partials 1356 1337 -19
Flags with carried forward coverage won't be shown. Click here to find out more.
|
* fix(x/ecocredit): bridge and bridge receive message validation * add and update tests * add ethereum contract scenario * use sdkerros wrap not fmt * use steps for field length checks * use custom regen prefix
technicallyty
approved these changes
Jul 7, 2022
Comment on lines
+40
to
+41
| if m.Jurisdiction == "" { | ||
| return sdkerrors.ErrInvalidRequest.Wrap("jurisdiction cannot be empty") |
There was a problem hiding this comment.
maybe this is something we can catch in ValidateJurisdiction? ok either way or perhaps a followup PR
There was a problem hiding this comment.
Yea, I was thinking the same thing but I think a followup would be better. Opened #1245.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ref: #893
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change