Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(app): add regen denom metadata migration #1209

Merged
merged 5 commits into from
Jun 24, 2022

Conversation

aleem1314
Copy link
Contributor

@aleem1314 aleem1314 commented Jun 23, 2022

Description

Closes: #1169


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@codecov
Copy link

codecov bot commented Jun 23, 2022

Codecov Report

Merging #1209 (7c22124) into master (66dca25) will decrease coverage by 0.02%.
The diff coverage is 60.00%.

@@            Coverage Diff             @@
##           master    #1209      +/-   ##
==========================================
- Coverage   70.27%   70.25%   -0.03%     
==========================================
  Files         235      235              
  Lines       23965    23975      +10     
==========================================
+ Hits        16842    16844       +2     
- Misses       5672     5680       +8     
  Partials     1451     1451              
Flag Coverage Δ
experimental-codecov 70.22% <ø> (+<0.01%) ⬆️
stable-codecov 65.00% <60.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@aleem1314 aleem1314 marked this pull request as ready for review June 23, 2022 14:52
Copy link
Contributor

@technicallyty technicallyty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

app/stable_appconfig.go Outdated Show resolved Hide resolved
aleem1314 and others added 2 commits June 23, 2022 21:53
Co-authored-by: Tyler <48813565+technicallyty@users.noreply.github.com>
Copy link
Member

@ryanchristo ryanchristo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@ryanchristo ryanchristo merged commit ede4a37 into master Jun 24, 2022
@ryanchristo ryanchristo deleted the aleem/1169-denom-metadata-migration branch June 24, 2022 02:26
@ryanchristo ryanchristo mentioned this pull request Jun 27, 2022
31 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Genesis vaildation fails for mainnet export
3 participants