Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(app): add basket denom units migration #1205

Merged
merged 5 commits into from
Jun 23, 2022

Conversation

aleem1314
Copy link
Contributor

@aleem1314 aleem1314 commented Jun 22, 2022

Description

Closes: #1204


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@codecov
Copy link

codecov bot commented Jun 22, 2022

Codecov Report

Merging #1205 (21df224) into master (66441cc) will increase coverage by 0.14%.
The diff coverage is 84.61%.

@@            Coverage Diff             @@
##           master    #1205      +/-   ##
==========================================
+ Coverage   70.12%   70.26%   +0.14%     
==========================================
  Files         235      235              
  Lines       23983    23965      -18     
==========================================
+ Hits        16818    16840      +22     
+ Misses       5716     5679      -37     
+ Partials     1449     1446       -3     
Flag Coverage Δ
experimental-codecov 70.21% <ø> (+0.02%) ⬆️
stable-codecov 65.05% <84.61%> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@aleem1314 aleem1314 marked this pull request as ready for review June 22, 2022 14:42
@aleem1314 aleem1314 requested review from anilcse and ryanchristo June 22, 2022 15:29
Copy link
Member

@ryanchristo ryanchristo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. We should remove the dependency on the wasmd package though.

app/denom_units_test.go Outdated Show resolved Hide resolved
app/denom_units_test.go Outdated Show resolved Hide resolved
app/denom_units_test.go Outdated Show resolved Hide resolved
Copy link
Contributor

@technicallyty technicallyty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ryanchristo ryanchristo merged commit 66dca25 into master Jun 23, 2022
@ryanchristo ryanchristo deleted the aleem/1204-denom-units-migrations branch June 23, 2022 23:07
@ryanchristo ryanchristo mentioned this pull request Jun 27, 2022
31 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate bank denom units for basket tokens
3 participants