-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(basket)!: store basket denom units in ascending order #1202
Conversation
denomUnits := make([]*banktypes.DenomUnit, 0) | ||
|
||
// Set denomination units in ascending order and | ||
// the first denomination unit must be the base |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codecov Report
@@ Coverage Diff @@
## master #1202 +/- ##
==========================================
- Coverage 70.26% 70.12% -0.15%
==========================================
Files 234 235 +1
Lines 23595 23781 +186
==========================================
+ Hits 16580 16677 +97
- Misses 5605 5669 +64
- Partials 1410 1435 +25
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. As discussed on our call, we will need a manual migration for redwood and we don't have baskets on mainnet so we should be in the clear there.
Opened #1204 as a followup. |
Description
Ref: #1190(comment)
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change