-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(x/ecocredit): clean up ecocredit transaction commads #1199
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1199 +/- ##
==========================================
- Coverage 70.32% 66.06% -4.27%
==========================================
Files 235 236 +1
Lines 23976 22358 -1618
==========================================
- Hits 16862 14770 -2092
- Misses 5658 6245 +587
+ Partials 1456 1343 -113
Flags with carried forward coverage won't be shown. Click here to find out more. |
I can break this up if need be. There are still improvements that could be made to the transaction commands, specifically the descriptions and examples, but this pull request is already pretty large so a followup might make more sense. |
// CheckDuplicateKey checks duplicate keys in JSON | ||
func CheckDuplicateKey(d *json.Decoder, path []string) error { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was moved outside ecocredit/client
so that it could be reused in ecocredits/client/marketplace
and ecocredit/client/basket
without import issues. Also might be helpful in other parts of the code in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice! good stuff 💪🏻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Description
Ref: #715 / Ref: #1041
This pull request makes the following changes:
ValidateBasic
)Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change