Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(x/ecocredit): basket query service revisions #1198

Merged
merged 5 commits into from
Jun 20, 2022

Conversation

ryanchristo
Copy link
Member

@ryanchristo ryanchristo commented Jun 17, 2022

Description

Ref: #715 / Closes: #1152

This pull request completes the audit of the basket query service:

  • Add alternative bindings for grpc query endpoints (non-breaking)
  • Add client integration tests (grpc and query commands)

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@ryanchristo ryanchristo mentioned this pull request Jun 17, 2022
31 tasks
@codecov
Copy link

codecov bot commented Jun 17, 2022

Codecov Report

Merging #1198 (491342e) into master (46af1a4) will increase coverage by 0.66%.
The diff coverage is 99.39%.

@@            Coverage Diff             @@
##           master    #1198      +/-   ##
==========================================
+ Coverage   69.57%   70.23%   +0.66%     
==========================================
  Files         232      234       +2     
  Lines       23267    23595     +328     
==========================================
+ Hits        16189    16573     +384     
+ Misses       5687     5610      -77     
- Partials     1391     1412      +21     
Flag Coverage Δ
experimental-codecov 70.31% <99.39%> (+0.70%) ⬆️
stable-codecov 64.87% <99.39%> (+0.80%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@technicallyty technicallyty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ryanchristo ryanchristo merged commit cb4993b into master Jun 20, 2022
@ryanchristo ryanchristo deleted the ryan/1152-basket-queries branch June 20, 2022 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent gRPC REST endpoint format
3 participants