Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(x/ecocredit): update core supply and basket field names #1192

Merged
merged 13 commits into from
Jun 23, 2022

Conversation

ryanchristo
Copy link
Member

@ryanchristo ryanchristo commented Jun 16, 2022

Description

Ref: #715

  • Updates deprecation comments in basket proto package
  • Updates tradable_supply and retired_supply to tradable_amount and retired_amount
  • Reverts retirement_location to retirement_jurisdiction in MsgTake and adds retirement_jurisdiction

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@codecov
Copy link

codecov bot commented Jun 16, 2022

Codecov Report

Merging #1192 (cf200ad) into master (d7c114c) will decrease coverage by 0.14%.
The diff coverage is 82.75%.

❗ Current head cf200ad differs from pull request most recent head 1ac4ede. Consider uploading reports for the commit 1ac4ede to get more accurate results

@@            Coverage Diff             @@
##           master    #1192      +/-   ##
==========================================
- Coverage   70.35%   70.20%   -0.15%     
==========================================
  Files         234      234              
  Lines       23575    23638      +63     
==========================================
+ Hits        16587    16596       +9     
- Misses       5569     5620      +51     
- Partials     1419     1422       +3     
Flag Coverage Δ
experimental-codecov 70.23% <82.75%> (-0.18%) ⬇️
stable-codecov 64.86% <82.75%> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ryanchristo ryanchristo marked this pull request as ready for review June 16, 2022 19:00
Copy link
Contributor

@technicallyty technicallyty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

proto/regen/ecocredit/basket/v1/tx.proto Outdated Show resolved Hide resolved
proto/regen/ecocredit/basket/v1/tx.proto Outdated Show resolved Hide resolved
ryanchristo and others added 2 commits June 16, 2022 13:26
Co-authored-by: Tyler <48813565+technicallyty@users.noreply.github.com>
@ryanchristo ryanchristo mentioned this pull request Jun 16, 2022
19 tasks
@ryanchristo ryanchristo mentioned this pull request Jun 17, 2022
31 tasks
@ryanchristo
Copy link
Member Author

@aleem1314 can I get a review when you get a chance?

Copy link
Contributor

@aleem1314 aleem1314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ryanchristo ryanchristo merged commit 9b74887 into master Jun 23, 2022
@ryanchristo ryanchristo deleted the ryan/ecocredit-api-audit branch June 23, 2022 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants