-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(x/ecocredit): update core supply and basket field names #1192
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1192 +/- ##
==========================================
- Coverage 70.35% 70.20% -0.15%
==========================================
Files 234 234
Lines 23575 23638 +63
==========================================
+ Hits 16587 16596 +9
- Misses 5569 5620 +51
- Partials 1419 1422 +3
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Co-authored-by: Tyler <48813565+technicallyty@users.noreply.github.com>
@aleem1314 can I get a review when you get a chance? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Description
Ref: #715
tradable_supply
andretired_supply
totradable_amount
andretired_amount
retirement_location
toretirement_jurisdiction
inMsgTake
and addsretirement_jurisdiction
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change