Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(x/ecocredit): update unit test setup for generate addresses #1182

Conversation

sfishel18
Copy link
Contributor

@sfishel18 sfishel18 commented Jun 13, 2022

…ses (#922)

Description

Closes: #922


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@sfishel18
Copy link
Contributor Author

👋 hello! i came across this repo searching for open-source projects working to fight climate change. this is a really interesting project and i'd love to contribute if i can

@codecov
Copy link

codecov bot commented Jun 13, 2022

Codecov Report

Merging #1182 (0447396) into master (322ab12) will decrease coverage by 0.03%.
The diff coverage is n/a.

❗ Current head 0447396 differs from pull request most recent head f123d47. Consider uploading reports for the commit f123d47 to get more accurate results

@@            Coverage Diff             @@
##           master    #1182      +/-   ##
==========================================
- Coverage   69.72%   69.68%   -0.04%     
==========================================
  Files         226      226              
  Lines       23035    23107      +72     
==========================================
+ Hits        16061    16103      +42     
- Misses       5593     5623      +30     
  Partials     1381     1381              
Flag Coverage Δ
experimental-codecov 69.74% <ø> (-0.05%) ⬇️
stable-codecov 64.16% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ryanchristo
Copy link
Member

@sfishel18 Thank you for opening a pull request! This looks good at first glance. I'll take a closer look later today.

Copy link
Member

@ryanchristo ryanchristo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. One small improvement that could be made. Pre-approving.

Thanks again for your contribution!

Comment on lines 103 to 107
_, _, otherAddr := testdata.KeyTestPubAddr()
_, _, noOrdersAddr := testdata.KeyTestPubAddr()

order1 := insertSellOrder(t, s, s.addr, 1)
order1 := insertSellOrder(t, s, s.addrs[0], 1)
order2 := insertSellOrder(t, s, otherAddr, 1)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we could use 3 addresses in this test and replace otherAddr and noOrdersAddr.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the catch :) fixed

Copy link
Contributor

@aleem1314 aleem1314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ryanchristo ryanchristo changed the title test(x/ecocredit): update unit test setup for generate list of addres… test(x/ecocredit): update unit test setup for generate addresses Jun 16, 2022
@ryanchristo ryanchristo enabled auto-merge (squash) June 16, 2022 17:01
@ryanchristo ryanchristo merged commit da06d47 into regen-network:master Jun 16, 2022
@sfishel18 sfishel18 deleted the sfishel/generate-addresses-in-test-setup branch June 17, 2022 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extend setupBase unit test suite to generate addresses
3 participants