-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(x/ecocredit): update unit test setup for generate addresses #1182
test(x/ecocredit): update unit test setup for generate addresses #1182
Conversation
👋 hello! i came across this repo searching for open-source projects working to fight climate change. this is a really interesting project and i'd love to contribute if i can |
Codecov Report
@@ Coverage Diff @@
## master #1182 +/- ##
==========================================
- Coverage 69.72% 69.68% -0.04%
==========================================
Files 226 226
Lines 23035 23107 +72
==========================================
+ Hits 16061 16103 +42
- Misses 5593 5623 +30
Partials 1381 1381
Flags with carried forward coverage won't be shown. Click here to find out more. |
@sfishel18 Thank you for opening a pull request! This looks good at first glance. I'll take a closer look later today. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. One small improvement that could be made. Pre-approving.
Thanks again for your contribution!
_, _, otherAddr := testdata.KeyTestPubAddr() | ||
_, _, noOrdersAddr := testdata.KeyTestPubAddr() | ||
|
||
order1 := insertSellOrder(t, s, s.addr, 1) | ||
order1 := insertSellOrder(t, s, s.addrs[0], 1) | ||
order2 := insertSellOrder(t, s, otherAddr, 1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like we could use 3
addresses in this test and replace otherAddr
and noOrdersAddr
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the catch :) fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…ses (#922)
Description
Closes: #922
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change