Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ecocredit): fix state migration #1180

Merged
merged 2 commits into from
Jun 13, 2022
Merged

Conversation

aleem1314
Copy link
Contributor

@aleem1314 aleem1314 commented Jun 10, 2022

Description

Closes: #1175


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@codecov
Copy link

codecov bot commented Jun 10, 2022

Codecov Report

❗ No coverage uploaded for pull request base (master@ba778bb). Click here to learn what that means.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master    #1180   +/-   ##
=========================================
  Coverage          ?   69.57%           
=========================================
  Files             ?      221           
  Lines             ?    23039           
  Branches          ?        0           
=========================================
  Hits              ?    16029           
  Misses            ?     5621           
  Partials          ?     1389           
Flag Coverage Δ
experimental-codecov 69.65% <100.00%> (?)
stable-codecov 64.04% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@aleem1314 aleem1314 marked this pull request as ready for review June 10, 2022 17:41
Copy link
Member

@ryanchristo ryanchristo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK. I'm guessing these are the changes we successfully tested with the temp testnet.

@ryanchristo ryanchristo merged commit 605e4cc into master Jun 13, 2022
@ryanchristo ryanchristo deleted the aleem/1175-fix-upgrade branch June 13, 2022 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Software upgrade is failing with mainnet export
3 participants